Re: [PATCH v2 net-next 6/7] socket: Replace most sock_create() calls with sock_create_kern().

Kuniyuki Iwashima
2025-06-04T18:20:23Z

From: Christoph Hellwig <hch@lst.de>
Date: Tue, 3 Jun 2025 06:50:21 +0200
> On Mon, Jun 02, 2025 at 02:52:47PM -0700, Kuniyuki Iwashima wrote:
> > From: Christoph Hellwig <hch@lst.de>
> > Date: Mon, 2 Jun 2025 07:09:49 +0200
> > > On Thu, May 29, 2025 at 08:03:06PM -0700, Kuniyuki Iwashima wrote:
> > > > I actually tried to to do so as sock_create_user() in the
> > > > previous series but was advised to avoid rename as the benefit
> > > > against LoC was low.
> > >
> > > I can't really parse this. What is the 'benefit against LoC'?
> >
> > It was a kind of subjective opinion whether the amount of changes
> > was worth or not.
>
> So the simple scripted renaming was not worth it. Maybe I misunderstand,
> but based on the reading we should basically have about a handful
> callers of the non-__kern variant left. Or is it a lot more?

Yes, after this series, only 2 sock_create() left, one in sctp and
another in core.