Re: [PATCH v2 net-next 1/7] socket: Un-export __sock_create().

Christoph Hellwig
2025-05-26T05:29:12Z

On Fri, May 23, 2025 at 11:21:07AM -0700, Kuniyuki Iwashima wrote:
> Since commit eeb1bd5c40ed ("net: Add a struct net parameter to
> sock_create_kern"), we no longer need to export __sock_create()
> and can replace all non-core users with sock_create_kern().
>
> Let's convert them and un-export __sock_create().

The changes looks good, but the commit log including subject line
is rather confusing. What you do is to replace all uses of
__sock_create with sock_create_kern, which works because
sock_create_kern just calls __sock_create with the last argument set
to 1 as those callers do it. This then allows marking __sock_create
static because all outside users are gone.

Please state that, i.e.

Subect: use sock_create_kern insteadf of opencoding it

Replace all callers of __sock_create that set the kernel argument to 1
with sock_create_kern, which is the improve interface for that.
Mark __sock_create static now that all users outside of socket.c
are gone.