Re: [PATCH net-next v4 01/11] net: Allow const args for of page_to_netmem()y

Dragos Tatulea
2025-06-12T08:06:50Z

On Wed, Jun 11, 2025 at 09:52:47PM -0700, Mina Almasry wrote:
> On Tue, Jun 10, 2025 at 8:15 AM Mark Bloch <mbloch@nvidia.com> wrote:
> >
> > From: Dragos Tatulea <dtatulea@nvidia.com>
> >
> > This allows calling page_to_netmem() with a const page * argument.
> >
> > Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
> > Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> > Signed-off-by: Mark Bloch <mbloch@nvidia.com>
>
> This is slightly better, it returns a const netmem_ref if const struct page:
>
> https://lore.kernel.org/netdev/20250609043225.77229-6-byungchul@sk.com/
>
Agree. Saw it too late though...

> It's probably too much of a hassle to block your series until
> Byungchul's change to this helper goes in for you, so this seems fine
> to me in the interim.
>
> Reviewed-by: Mina Almasry <almasrymina@google.com>
>
Thanks for the review!

Dragos