From: Leon Romanovsky <leon@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
Potnuri Bharat Teja <bharat@chelsio.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open()
Date: Thu, 12 Jun 2025 11:38:19 +0300 [thread overview]
Message-ID: <20250612083819.GS10669@unreal> (raw)
In-Reply-To: <cdc577a5-cebd-404a-b762-cc6fee0870dc@web.de>
On Tue, Jun 10, 2025 at 02:20:17PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 10 Jun 2025 14:14:09 +0200
>
> It can be known that the function “kfree” performs a null pointer check
> for its input parameter.
> It is therefore not needed to repeat such a check before its call.
>
> Thus remove a redundant pointer check.
>
> The source code was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/infiniband/hw/cxgb4/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 034b85c42255..c0eb166a49b9 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -905,7 +905,7 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev)
>
> return 0;
> err_free_status_page_and_wr_log:
> - if (c4iw_wr_log && rdev->wr_log)
> + if (c4iw_wr_log)
This is not needed too, fixed locally.
> kfree(rdev->wr_log);
> free_page((unsigned long)rdev->status_page);
> destroy_ocqp_pool:
> --
> 2.49.0
>
>
next prev parent reply other threads:[~2025-06-12 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 12:20 [PATCH] RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open() Markus Elfring
2025-06-12 8:38 ` Leon Romanovsky [this message]
2025-06-12 8:39 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612083819.GS10669@unreal \
--to=leon@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=bharat@chelsio.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox