From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9639927817C; Wed, 18 Jun 2025 07:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750230500; cv=none; b=PG2YHo464/rQwfrpjjkqxMtubEdLwKPrg6/FZ7AUDkzuefz36bk+O99RrJI9FkraC7aP+HFMbrEutzhIvzc2AePNM15gOSyTaeehFW2ALawK7UieRRw957nslvM/ttKJxfjfvvLZYSejBGjIpHBofZeZesQY44754mVdpR6PG/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750230500; c=relaxed/simple; bh=VgzO4u3etHcLffOF3xhhiZh9bVwVLrrF0zhyWf94M9M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ieeSHTQTkuT5BBa1UirJeD0hTObL7ctmjbyXmeXcbvy0bX00oLU9U7I5TDPGh6wKqtPWnbeXt/naeE+jOSH5ejctCBzDhVxgn0WdQ33uUGjNz9a3HEu6Td4Dk+ftElQrfe0DR2U3fPux6P2OO1Ij9Co9eH7OenUo9JA+lEIuETk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=iDPg3Mqb; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=3tzqTR45; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="iDPg3Mqb"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="3tzqTR45" From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1750230496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pnn4Hm43CIo/zzl8zpkEc7JtKaF/FVJfKrxwItM+yGQ=; b=iDPg3MqbrX4IK3hVciyJJKtY8Okjzk5VMBh4dRi8oNkcQdjrLdqvWd4dlHwM3PUIpUPElz DtQIJp/KXRdsOStSTESGCiRWn7kplEnQgGhnXssL5ilNnSOVTtKrDoYlkpROfUwtYQPTYa 8rNqxZpXmwASSzVXsSaQF8w8QOu/Z16SeTOqlLMTCp8wI7gMvRp0ujN4dquC8bQ7UCgq/R dLneKN2GHHxayQK4qFengglnG4f8Vc2Q42D4uXxbj4qKRcy9AJZL3RcKRthYvTdHyNNvP4 X7fG7jd/5K4O6bbzFQhY/oZVQ59GaAjC3OpKwX8a+FGSR3KbmtFLMD7OLFHznA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1750230496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pnn4Hm43CIo/zzl8zpkEc7JtKaF/FVJfKrxwItM+yGQ=; b=3tzqTR45S2VDKs4Spdxdu+o51E/aoxyzs9bZXBdY1C86VZPxFJ84CQ5cBk5zhnDZjFJCJy 2mHvWfP+XLz4LRBw== Date: Wed, 18 Jun 2025 09:08:06 +0200 Subject: [PATCH net-next v3 1/2] ice: Don't use %pK through printk or tracepoints Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250618-restricted-pointers-net-v3-1-3b7a531e58bb@linutronix.de> References: <20250618-restricted-pointers-net-v3-0-3b7a531e58bb@linutronix.de> In-Reply-To: <20250618-restricted-pointers-net-v3-0-3b7a531e58bb@linutronix.de> To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saeed Mahameed , Leon Romanovsky , Tariq Toukan Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Aleksandr Loktionov , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Developer-Signature: v=1; a=ed25519-sha256; t=1750230493; l=3588; i=thomas.weissschuh@linutronix.de; s=20240209; h=from:subject:message-id; bh=VgzO4u3etHcLffOF3xhhiZh9bVwVLrrF0zhyWf94M9M=; b=ZSn6tbJlBAQuZDrKZwcxind4Bzcli+CboU+yxVGcsUAndSbJCxxjcn4uyf10K/otTkoFJv81k MkzDi8UAsN7CqRFSohVHZ1sLl1VML81rr7KqkI+4bwBg51TXnQOhqZT X-Developer-Key: i=thomas.weissschuh@linutronix.de; a=ed25519; pk=pfvxvpFUDJV2h2nY0FidLUml22uGLSjByFbM6aqQQws= In the past %pK was preferable to %p as it would not leak raw pointer values into the kernel log. Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the regular %p has been improved to avoid this issue. Furthermore, restricted pointers ("%pK") were never meant to be used through printk(). They can still unintentionally leak raw pointers or acquire sleeping locks in atomic contexts. Switch to the regular pointer formatting which is safer and easier to reason about. There are still a few users of %pK left, but these use it through seq_file, for which its usage is safe. Signed-off-by: Thomas Weißschuh Acked-by: Przemek Kitszel Reviewed-by: Aleksandr Loktionov --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- drivers/net/ethernet/intel/ice/ice_trace.h | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index 0a11b4281092e25bb7b66d48867f7c4f9fb2286d..c94bf3b8c19ce8963ebcbc486c6f446c077762b1 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -9168,7 +9168,7 @@ static int ice_create_q_channels(struct ice_vsi *vsi) list_add_tail(&ch->list, &vsi->ch_list); vsi->tc_map_vsi[i] = ch->ch_vsi; dev_dbg(ice_pf_to_dev(pf), - "successfully created channel: VSI %pK\n", ch->ch_vsi); + "successfully created channel: VSI %p\n", ch->ch_vsi); } return 0; diff --git a/drivers/net/ethernet/intel/ice/ice_trace.h b/drivers/net/ethernet/intel/ice/ice_trace.h index 07aab6e130cd553fa1fcaa2feac9d14f0433239a..4f35ef8d6b299b4acd6c85992c2c93b164a88372 100644 --- a/drivers/net/ethernet/intel/ice/ice_trace.h +++ b/drivers/net/ethernet/intel/ice/ice_trace.h @@ -130,7 +130,7 @@ DECLARE_EVENT_CLASS(ice_tx_template, __entry->buf = buf; __assign_str(devname);), - TP_printk("netdev: %s ring: %pK desc: %pK buf %pK", __get_str(devname), + TP_printk("netdev: %s ring: %p desc: %p buf %p", __get_str(devname), __entry->ring, __entry->desc, __entry->buf) ); @@ -158,7 +158,7 @@ DECLARE_EVENT_CLASS(ice_rx_template, __entry->desc = desc; __assign_str(devname);), - TP_printk("netdev: %s ring: %pK desc: %pK", __get_str(devname), + TP_printk("netdev: %s ring: %p desc: %p", __get_str(devname), __entry->ring, __entry->desc) ); DEFINE_EVENT(ice_rx_template, ice_clean_rx_irq, @@ -182,7 +182,7 @@ DECLARE_EVENT_CLASS(ice_rx_indicate_template, __entry->skb = skb; __assign_str(devname);), - TP_printk("netdev: %s ring: %pK desc: %pK skb %pK", __get_str(devname), + TP_printk("netdev: %s ring: %p desc: %p skb %p", __get_str(devname), __entry->ring, __entry->desc, __entry->skb) ); @@ -205,7 +205,7 @@ DECLARE_EVENT_CLASS(ice_xmit_template, __entry->skb = skb; __assign_str(devname);), - TP_printk("netdev: %s skb: %pK ring: %pK", __get_str(devname), + TP_printk("netdev: %s skb: %p ring: %p", __get_str(devname), __entry->skb, __entry->ring) ); @@ -228,7 +228,7 @@ DECLARE_EVENT_CLASS(ice_tx_tstamp_template, TP_fast_assign(__entry->skb = skb; __entry->idx = idx;), - TP_printk("skb %pK idx %d", + TP_printk("skb %p idx %d", __entry->skb, __entry->idx) ); #define DEFINE_TX_TSTAMP_OP_EVENT(name) \ -- 2.49.0