* [PATCH v2] net/smc: replace strncpy with strscpy
@ 2025-06-20 10:25 Pranav Tyagi
2025-06-20 19:58 ` Simon Horman
2025-06-24 0:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Pranav Tyagi @ 2025-06-20 10:25 UTC (permalink / raw)
To: wenjia, jaka, davem, edumazet, kuba, pabeni, linux-rdma,
linux-s390, netdev, linux-kernel
Cc: alibuda, tonylu, guwen, horms, skhan, linux-kernel-mentees,
Pranav Tyagi
Replace the deprecated strncpy() with two-argument version of
strscpy() as the destination is an array
and should be NUL-terminated.
Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
---
net/smc/smc_pnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
index b391c2ef463f..76ad29e31d60 100644
--- a/net/smc/smc_pnet.c
+++ b/net/smc/smc_pnet.c
@@ -370,7 +370,7 @@ static int smc_pnet_add_eth(struct smc_pnettable *pnettable, struct net *net,
goto out_put;
new_pe->type = SMC_PNET_ETH;
memcpy(new_pe->pnet_name, pnet_name, SMC_MAX_PNETID_LEN);
- strncpy(new_pe->eth_name, eth_name, IFNAMSIZ);
+ strscpy(new_pe->eth_name, eth_name);
rc = -EEXIST;
new_netdev = true;
mutex_lock(&pnettable->lock);
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net/smc: replace strncpy with strscpy
2025-06-20 10:25 [PATCH v2] net/smc: replace strncpy with strscpy Pranav Tyagi
@ 2025-06-20 19:58 ` Simon Horman
2025-06-24 0:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-06-20 19:58 UTC (permalink / raw)
To: Pranav Tyagi
Cc: wenjia, jaka, davem, edumazet, kuba, pabeni, linux-rdma,
linux-s390, netdev, linux-kernel, alibuda, tonylu, guwen, skhan,
linux-kernel-mentees
On Fri, Jun 20, 2025 at 03:55:59PM +0530, Pranav Tyagi wrote:
> Replace the deprecated strncpy() with two-argument version of
> strscpy() as the destination is an array
> and should be NUL-terminated.
>
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
Thanks for the update.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net/smc: replace strncpy with strscpy
2025-06-20 10:25 [PATCH v2] net/smc: replace strncpy with strscpy Pranav Tyagi
2025-06-20 19:58 ` Simon Horman
@ 2025-06-24 0:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-06-24 0:10 UTC (permalink / raw)
To: Pranav Tyagi
Cc: wenjia, jaka, davem, edumazet, kuba, pabeni, linux-rdma,
linux-s390, netdev, linux-kernel, alibuda, tonylu, guwen, horms,
skhan, linux-kernel-mentees
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 20 Jun 2025 15:55:59 +0530 you wrote:
> Replace the deprecated strncpy() with two-argument version of
> strscpy() as the destination is an array
> and should be NUL-terminated.
>
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
> ---
> net/smc/smc_pnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [v2] net/smc: replace strncpy with strscpy
https://git.kernel.org/netdev/net-next/c/ae2402bf882b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-24 0:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-20 10:25 [PATCH v2] net/smc: replace strncpy with strscpy Pranav Tyagi
2025-06-20 19:58 ` Simon Horman
2025-06-24 0:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).