Re: [PATCH rdma-next v1 7/8] IB: Extend UVERBS_METHOD_REG_MR to get DMAH

[Leon Romanovsky <leon@kernel.org>]

On Sun, Jul 13, 2025 at 03:04:16PM -0700, Zhu Yanjun wrote:
> 在 2025/7/12 23:37, Leon Romanovsky 写道:
> > From: Yishai Hadas <yishaih@nvidia.com>
> > 
> > Extend UVERBS_METHOD_REG_MR to get DMAH and pass it to all drivers.
> > 
> > It will be used in mlx5 driver as part of the next patch from the
> > series.
> > 
> > Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
> > Reviewed-by: Edward Srouji <edwards@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> >   drivers/infiniband/core/uverbs_cmd.c          |  2 +-
> >   drivers/infiniband/core/uverbs_std_types_mr.c | 27 +++++++++++++++----
> >   drivers/infiniband/core/verbs.c               |  5 +++-
> >   drivers/infiniband/hw/bnxt_re/ib_verbs.c      |  8 ++++++
> >   drivers/infiniband/hw/bnxt_re/ib_verbs.h      |  2 ++
> >   drivers/infiniband/hw/cxgb4/iw_cxgb4.h        |  1 +
> >   drivers/infiniband/hw/cxgb4/mem.c             |  6 ++++-
> >   drivers/infiniband/hw/efa/efa.h               |  2 ++
> >   drivers/infiniband/hw/efa/efa_verbs.c         | 12 +++++++++
> >   drivers/infiniband/hw/erdma/erdma_verbs.c     |  6 ++++-
> >   drivers/infiniband/hw/erdma/erdma_verbs.h     |  3 ++-
> >   drivers/infiniband/hw/hns/hns_roce_device.h   |  1 +
> >   drivers/infiniband/hw/hns/hns_roce_mr.c       |  6 +++++
> >   drivers/infiniband/hw/irdma/verbs.c           |  9 +++++++
> >   drivers/infiniband/hw/mana/mana_ib.h          |  2 ++
> >   drivers/infiniband/hw/mana/mr.c               |  8 ++++++
> >   drivers/infiniband/hw/mlx4/mlx4_ib.h          |  1 +
> >   drivers/infiniband/hw/mlx4/mr.c               |  4 +++
> >   drivers/infiniband/hw/mlx5/mlx5_ib.h          |  2 ++
> >   drivers/infiniband/hw/mlx5/mr.c               |  8 +++---
> >   drivers/infiniband/hw/mthca/mthca_provider.c  |  6 ++++-
> >   drivers/infiniband/hw/ocrdma/ocrdma_verbs.c   |  6 ++++-
> >   drivers/infiniband/hw/ocrdma/ocrdma_verbs.h   |  3 ++-
> >   drivers/infiniband/hw/qedr/verbs.c            |  6 ++++-
> >   drivers/infiniband/hw/qedr/verbs.h            |  3 ++-
> >   drivers/infiniband/hw/usnic/usnic_ib_verbs.c  |  4 +++
> >   drivers/infiniband/hw/usnic/usnic_ib_verbs.h  |  1 +
> >   drivers/infiniband/hw/vmw_pvrdma/pvrdma_mr.c  |  5 ++++
> >   .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h   |  1 +
> >   drivers/infiniband/sw/rdmavt/mr.c             |  5 ++++
> >   drivers/infiniband/sw/rdmavt/mr.h             |  1 +
> >   drivers/infiniband/sw/rxe/rxe_verbs.c         |  4 +++
> >   drivers/infiniband/sw/siw/siw_verbs.c         |  7 ++++-
> >   drivers/infiniband/sw/siw/siw_verbs.h         |  3 ++-
> >   include/rdma/ib_verbs.h                       |  3 +++
> >   include/uapi/rdma/ib_user_ioctl_cmds.h        |  1 +
> >   36 files changed, 154 insertions(+), 20 deletions(-)

<...>

> > +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> > @@ -1271,6 +1271,7 @@ static struct ib_mr *rxe_get_dma_mr(struct ib_pd *ibpd, int access)
> >   static struct ib_mr *rxe_reg_user_mr(struct ib_pd *ibpd, u64 start,
> >   				     u64 length, u64 iova, int access,
> > +				     struct ib_dmah *dmah,
> >   				     struct ib_udata *udata)
> >   {
> >   	struct rxe_dev *rxe = to_rdev(ibpd->device);
> > @@ -1278,6 +1279,9 @@ static struct ib_mr *rxe_reg_user_mr(struct ib_pd *ibpd, u64 start,
> >   	struct rxe_mr *mr;
> >   	int err, cleanup_err;
> > +	if (dmah)
> > +		return ERR_PTR(-EOPNOTSUPP);
> 
> Thanks. If I get this patchset correctly, this patchset is based on the PCIe
> features TPH(TLP Processing Hints),  Steering Tags and Processing Hints. RXE
> is an emulation RDMA driver. Thus it can not support this DMAH feature
> because rxe does not have PCIe features support (THP, Steering Tags and
> Processing Hints).
> 
> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Thanks, and BTW please trim the emails while replying.