Re: [PATCH for-next 06/23] RDMA/hfi1: Remove opa_vnic

Dennis Dalessandro
2025-07-01T17:19:35Z

On 7/1/25 12:00 PM, Leon Romanovsky wrote:
> On Tue, Jul 01, 2025 at 09:44:05AM -0400, Dennis Dalessandro wrote:
>> On 7/1/25 8:38 AM, Leon Romanovsky wrote:
>>> On Mon, Jun 30, 2025 at 11:30:17AM -0400, Dennis Dalessandro wrote:
>>>> OPA Vnic has been abandoned and left to rot. Time to excise.
>>>>
>>>> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
>>>> ---
>>>> Documentation/infiniband/opa_vnic.rst | 159 ---
>>>> .../translations/zh_CN/infiniband/opa_vnic.rst | 156 ---
>>>> MAINTAINERS | 6
>>>> drivers/infiniband/Kconfig | 2
>>>> drivers/infiniband/hw/hfi1/Makefile | 4
>>>> drivers/infiniband/hw/hfi1/aspm.c | 2
>>>> drivers/infiniband/hw/hfi1/chip.c | 54 -
>>>> drivers/infiniband/hw/hfi1/chip.h | 2
>>>> drivers/infiniband/hw/hfi1/driver.c | 13
>>>> drivers/infiniband/hw/hfi1/hfi.h | 20
>>>> drivers/infiniband/hw/hfi1/init.c | 4
>>>> drivers/infiniband/hw/hfi1/mad.c | 1
>>>> drivers/infiniband/hw/hfi1/msix.c | 4
>>>> drivers/infiniband/hw/hfi1/netdev.h | 8
>>>> drivers/infiniband/hw/hfi1/netdev_rx.c | 3
>>>> drivers/infiniband/hw/hfi1/verbs.c | 2
>>>> drivers/infiniband/hw/hfi1/vnic.h | 126 --
>>>> drivers/infiniband/hw/hfi1/vnic_main.c | 615 ------------
>>>> drivers/infiniband/hw/hfi1/vnic_sdma.c | 282 -----
>>>> drivers/infiniband/ulp/Makefile | 1
>>>> drivers/infiniband/ulp/opa_vnic/Kconfig | 9
>>>> drivers/infiniband/ulp/opa_vnic/Makefile | 9
>>>> drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.c | 513 ----------
>>>> drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h | 524 ----------
>>>> drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c | 183 ---
>>>> .../infiniband/ulp/opa_vnic/opa_vnic_internal.h | 329 ------
>>>> drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c | 400 --------
>>>> drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 1056 --------------------
>>>> .../infiniband/ulp/opa_vnic/opa_vnic_vema_iface.c | 390 -------
>>>> 29 files changed, 20 insertions(+), 4857 deletions(-)
>>>> delete mode 100644 Documentation/infiniband/opa_vnic.rst
>>>> delete mode 100644 Documentation/translations/zh_CN/infiniband/opa_vnic.rst
>>>> delete mode 100644 drivers/infiniband/hw/hfi1/vnic.h
>>>> delete mode 100644 drivers/infiniband/hw/hfi1/vnic_main.c
>>>> delete mode 100644 drivers/infiniband/hw/hfi1/vnic_sdma.c
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/Kconfig
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/Makefile
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.c
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
>>>> delete mode 100644 drivers/infiniband/ulp/opa_vnic/opa_vnic_vema_iface.c
>>>
>>> It is not complete, after applying the patch:
>>> ➜ kernel git:(wip/leon-for-next) git grep -c -i opa_vnic
>>> Documentation/driver-api/infiniband.rst:4
>>> Documentation/infiniband/index.rst:1
>>> Documentation/translations/zh_CN/infiniband/index.rst:1
>>> include/rdma/ib_verbs.h:2
>>> include/rdma/opa_vnic.h:24
>>
>> Ah! Will get rid of those in the next iteration.
>
> Send opa_vnic separately, it is independent.

Sounds like a good idea. Will do that.

-Denny