Re: [PATCH for-next 13/23] RDMA/hfi2: Add system core header files

Jason Gunthorpe
2025-08-25T14:43:03Z

On Mon, Jun 30, 2025 at 11:30:53AM -0400, Dennis Dalessandro wrote:
> diff --git a/drivers/infiniband/hw/hfi2/device.h b/drivers/infiniband/hw/hfi2/device.h
> new file mode 100644
> index 000000000000..8948b9a48ac4
> --- /dev/null
> +++ b/drivers/infiniband/hw/hfi2/device.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
> +/*
> + * Copyright(c) 2015, 2016 Intel Corporation.
> + */
> +
> +#ifndef _HFI2_DEVICE_H
> +#define _HFI2_DEVICE_H
> +
> +int hfi2_cdev_init(int minor, const char *name,
> + const struct file_operations *fops,
> + struct cdev *cdev, struct device **devp,
> + bool user_accessible,
> + struct kobject *parent);
> +void hfi2_cdev_cleanup(struct cdev *cdev, struct device **devp);

Seems like these are never defined, should be cleaned up

Jason