Re: [PATCH for-next 05/23] RDMA/core: Add writev to uverbs file descriptor

Leon Romanovsky
2025-07-01T16:04:20Z

On Tue, Jul 01, 2025 at 09:57:23AM -0400, Dennis Dalessandro wrote:
> On 7/1/25 8:32 AM, Leon Romanovsky wrote:
> > On Mon, Jun 30, 2025 at 11:30:12AM -0400, Dennis Dalessandro wrote:
> >> From: Dean Luick <dean.luick@cornelisnetworks.com>
> >>
> >> Add a writev pass-through between the uverbs file descriptor and
> >> infiniband devices. Interested devices may subscribe to this
> >> functionality.
> >
> > Aren't we use IOCTL and not write interface now?
> > Why do we need this?
>
> We wanted to keep all the semantics of the user interface the same so it's an
> easy migration to the uverbs cdev from the private cdev. The idea is that all
> the command and control is still ioctl, but the "data path" is still using the
> writev() to pass in the iovecs.

ok, just add this to the commit message.

>
> By the way I'll get the rdma_core (user space) changes posted soon so you can
> see both sides.

BTW, I looked whole series and upto MAD/verbs interface everything looks ok.
The latter simply broke me with >3K LOC in single patch.

Thanks

>
> -Denny