Re: [PATCH rdma-next 4/9] RDMA/bnxt_re: Avoid GID level QoS update from the driver

[Leon Romanovsky <leon@kernel.org>]

On Thu, Aug 14, 2025 at 04:55:50PM +0530, Kalesh AP wrote:
> From: Shravya KN <shravya.k-n@broadcom.com>
> 
> The driver inserts a VLAN header into RoCE packets when the
> traffic was untagged by modifying the existing GID entries.
> This has caused the firmware to enforce only VLAN-based
> priority mappings, ignoring other valid priority configurations
> set via APP TLVs (e.g., DSCP selectors).
> 
> Driver now has support for selecting the service level (vlan id)
> and traffic class (dscp) during modify_qp. So no need to override
> the priority update using the update gid method. Hence removing
> the code that handles the above operation.
> 
> Signed-off-by: Shravya KN <shravya.k-n@broadcom.com>
> Reviewed-by: Saravanan Vajravel <saravanan.vajravel@broadcom.com>
> Reviewed-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c     | 94 ------------------------
>  drivers/infiniband/hw/bnxt_re/qplib_sp.c | 40 ----------
>  2 files changed, 134 deletions(-)

<...>

> -
> -		INIT_DELAYED_WORK(&rdev->worker, bnxt_re_worker);
> -		set_bit(BNXT_RE_FLAG_QOS_WORK_REG, &rdev->flags);

You should delete worker from struct bnxt_re_dev and
BNXT_RE_FLAG_QOS_WORK_REG too.

Thanks