From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 011A02E06EF for ; Mon, 8 Sep 2025 07:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757315074; cv=none; b=tzw5aBSw+iJQ03Thvi91zQPeRiyFSZb52DOAkUbOGvkksFY0UiQynB3bgtwNxp41FwjkOXnmkcgyjnGfv9yeqaZfX3Kt4akS+/hLxTFg7fvFVWaYGd7t9KhPyPYIVaB96MTP2YPBq/NptAuXynVU1IJAB/xugu9wsiS+p7jtuxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757315074; c=relaxed/simple; bh=9BxETapSLWjN3S8JGQJx9PLAGbIRUno0tu32lZ+u8Y4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ufl14yn9kAwAOfJgQ5XTwe/+MPxoF6sPDIBcBLg0yxx8vJyUTXPKskAIJPYyyme8NOh+CQt6fB2h/FSJnhqBEgfHRABIpUH8RSLbQXrxzDpT30c0nP09+9127ST0XGP24MiydGXKS+GO6AtgJME63fnevzN8tFEAjp7baAQ5eqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qOqvzagB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qOqvzagB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AFB5C4CEF5; Mon, 8 Sep 2025 07:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757315073; bh=9BxETapSLWjN3S8JGQJx9PLAGbIRUno0tu32lZ+u8Y4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qOqvzagBZKSHm1dkZ6LCGzFqf6Qd3vuK4xMBQXJO7TYijDvxlKI3Z7lTHNmv1Nb5G rqP0ohHrq/6WukLFrqeW8BRL4Lxu7SQoY8v37jNec0kzk6lvTokqDJpi3mhlWPTk3R EX+cFH1sANmFAJbNT0KwNOsFbwzGaDF0vx/09gUsux/vFYw3LKs/+z1LBKNBFWQwTU 8MjqZ4t3RNzb0pyVvUCjvo7/cIS/EZBCimwbJU3aNRtJd034obfxuRHExvYlwmXAnJ PB08sAFpeGehNfCjT24ktUVGK46V34CrJGECo8PEDL5Ir1e/5lpS3KHZjIiGDUvM78 4KHUmtGpsZxfg== Date: Mon, 8 Sep 2025 10:04:28 +0300 From: Leon Romanovsky To: Kalesh AP Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, selvin.xavier@broadcom.com, Shravya KN , Saravanan Vajravel Subject: Re: [PATCH rdma-next 4/9] RDMA/bnxt_re: Avoid GID level QoS update from the driver Message-ID: <20250908070428.GD25881@unreal> References: <20250814112555.221665-1-kalesh-anakkur.purayil@broadcom.com> <20250814112555.221665-5-kalesh-anakkur.purayil@broadcom.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250814112555.221665-5-kalesh-anakkur.purayil@broadcom.com> On Thu, Aug 14, 2025 at 04:55:50PM +0530, Kalesh AP wrote: > From: Shravya KN > > The driver inserts a VLAN header into RoCE packets when the > traffic was untagged by modifying the existing GID entries. > This has caused the firmware to enforce only VLAN-based > priority mappings, ignoring other valid priority configurations > set via APP TLVs (e.g., DSCP selectors). > > Driver now has support for selecting the service level (vlan id) > and traffic class (dscp) during modify_qp. So no need to override > the priority update using the update gid method. Hence removing > the code that handles the above operation. > > Signed-off-by: Shravya KN > Reviewed-by: Saravanan Vajravel > Reviewed-by: Selvin Xavier > --- > drivers/infiniband/hw/bnxt_re/main.c | 94 ------------------------ > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 40 ---------- > 2 files changed, 134 deletions(-) <...> > - > - INIT_DELAYED_WORK(&rdev->worker, bnxt_re_worker); > - set_bit(BNXT_RE_FLAG_QOS_WORK_REG, &rdev->flags); You should delete worker from struct bnxt_re_dev and BNXT_RE_FLAG_QOS_WORK_REG too. Thanks