From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B79572DF122; Mon, 3 Nov 2025 22:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762208039; cv=none; b=J58EgCYmMRU3f82z+pu3e01imxbx5L8ltxNuqRFsEqIMFFKuLL5j54mC+A6vcypA0Urj0UKbpLz6GbqFYKYdFVV/7oiFe1n+uJ/nmmeNqyWa4IrMHA0ZCrolKaKXF71zAAmgwj12nZin3uEEc6gjDJi2eFHBdkwhopD5nFyX600= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762208039; c=relaxed/simple; bh=G5G/nJ6BwUDbjhos8smIO/3KjLQpgzD5ntWtzL13rts=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DS0P2BjMSjQokhmuSHQORVqSaE5npmz5x9g1twdhfptkWvDdwf8lcHjDulSjMplLDlAZLV8MDPtKonq/+zFKTL8q57oIdzp9Q0oEksZnk439CSgphQ6yuvqSDm8oU5nyvbqlR8HG7gYbS28sKAX/YlxwNvRtSr1n9t6cPycrAeM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VTLqZ0hL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VTLqZ0hL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24CA6C4CEE7; Mon, 3 Nov 2025 22:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762208039; bh=G5G/nJ6BwUDbjhos8smIO/3KjLQpgzD5ntWtzL13rts=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VTLqZ0hL1/6PHxQ6NOhzlLM6gCmDmZLOEBjsopkNlCfT1UDEUzEpPJ9dRNKIC0lpk 5IP+NEjFrjtzZVi9MxoejBWIBOkHCXcmGUgODEYUdCpVLHPVh0cAJSOTWB1fhrl1iF z5hTda/0Y1Q5VJjkd598Vr+sNABtNOoGLJsImaT4TxCqGru5AW2vpM+yUdVgTQvw9e /xQrqh0iCogqr918cBXp+vPSsanb+KqgUvy7E+gfIndbbpFuHJomc+J7CSVORGK8ey IER03KXPAHJ9fglF87N61IoFLE7kR2HkjQvV097joGTXbveYEVNBBe/8GgHu9hoePF 1hperBfe4REqA== Date: Mon, 3 Nov 2025 14:13:56 -0800 From: Jakub Kicinski To: Daniel Zahka Cc: Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Srujana Challa , Bharat Bhushan , Herbert Xu , Brett Creeley , Andrew Lunn , Michael Chan , Pavan Chebbi , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Manish Chopra , Maxime Coquelin , Alexandre Torgue , Siddharth Vadapalli , Roger Quadros , Loic Poulain , Sergey Ryazanov , Johannes Berg , Vladimir Oltean , Michal Swiatkowski , Aleksandr Loktionov , Dave Ertman , Vlad Dumitrescu , "Russell King (Oracle)" , Alexander Sverdlin , Lorenzo Bianconi , netdev@vger.kernel.org, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH net-next v2 1/2] devlink: pass extack through to devlink_param::get() Message-ID: <20251103141356.3470701b@kernel.org> In-Reply-To: <20251103194554.3203178-2-daniel.zahka@gmail.com> References: <20251103194554.3203178-1-daniel.zahka@gmail.com> <20251103194554.3203178-2-daniel.zahka@gmail.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 3 Nov 2025 11:45:52 -0800 Daniel Zahka wrote: > Allow devlink_param::get() handlers to report error messages via > extack. This function is called in a few different contexts, but not > all of them will have an valid extack to use. > > When devlink_param::get() is called from param_get_doit or > param_get_dumpit contexts, pass the extack through so that drivers can > report errors when retrieving param values. devlink_param::get() is > called from the context of devlink_param_notify(), pass NULL in for > the extack. Warning: drivers/net/ethernet/intel/ice/devlink/devlink.c:618 function parameter 'extack' not described in 'ice_devlink_tx_sched_layers_get' Warning: drivers/net/ethernet/intel/ice/devlink/devlink.c:1533 function parameter 'extack' not described in 'ice_devlink_local_fwd_get' -- pw-bot: cr