From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Ma Ke <make24@iscas.ac.cn>,
haris.iqbal@ionos.com, jinpu.wang@ionos.com,
danil.kipnis@cloud.ionos.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
stable@vger.kernel.org
Subject: Re: [PATCH] RDMA/rtrs: server: Fix error handling in get_or_create_srv
Date: Wed, 5 Nov 2025 09:46:59 -0400 [thread overview]
Message-ID: <20251105134659.GM1204670@ziepe.ca> (raw)
In-Reply-To: <20251105125713.GC16832@unreal>
On Wed, Nov 05, 2025 at 02:57:13PM +0200, Leon Romanovsky wrote:
> On Tue, Nov 04, 2025 at 10:19:00AM +0800, Ma Ke wrote:
> > get_or_create_srv() fails to call put_device() after
> > device_initialize() when memory allocation fails. This could cause
> > reference count leaks during error handling, preventing proper device
> > cleanup and resulting in memory leaks.
>
> Nothing from above is true. put_device is preferable way to release
> memory after call to device_initialize(), but direct call to kfree is
> also fine.
Once device_initialize() happens you must call put_device(), it is one
of Greg's rules.
Jason
next prev parent reply other threads:[~2025-11-05 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 2:19 [PATCH] RDMA/rtrs: server: Fix error handling in get_or_create_srv Ma Ke
2025-11-04 6:34 ` Jinpu Wang
2025-11-04 14:55 ` Markus Elfring
2025-11-05 12:57 ` Leon Romanovsky
2025-11-05 13:46 ` Jason Gunthorpe [this message]
2025-11-05 14:51 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105134659.GM1204670@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=akpm@linux-foundation.org \
--cc=danil.kipnis@cloud.ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox