From: Jason Gunthorpe <jgg@ziepe.ca>
To: Vlad Dumitrescu <vdumitrescu@nvidia.com>
Cc: Kriish Sharma <kriish.sharma2006@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
Parav Pandit <parav@nvidia.com>,
Edward Srouji <edwards@nvidia.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+938fcd548c303fe33c1a@syzkaller.appspotmail.com
Subject: Re: [PATCH] RDMA/core: Fix uninitialized gid in ib_nl_process_good_ip_rsep()
Date: Fri, 7 Nov 2025 15:17:36 -0400 [thread overview]
Message-ID: <20251107191736.GC1859178@ziepe.ca> (raw)
In-Reply-To: <c9c8b90f-4edb-47da-8ad0-94f9e58d71e0@nvidia.com>
On Fri, Nov 07, 2025 at 11:11:40AM -0800, Vlad Dumitrescu wrote:
> On 11/7/25 07:37, Jason Gunthorpe wrote:
> > The fix to whatever this is should be in ib_nl_is_good_ip_resp().
>
> nla_parse_deprecated returns success if attrs are missing?
>
> Other callers also check for their expected attrs to be present in tb,
> after checking nla_parse_deprecated()'s return code.
That sounds like the trouble then, the check for tb presence should be
added to the ib_nl_is_good_ip_resp..
Jason
next prev parent reply other threads:[~2025-11-07 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 4:10 [PATCH] RDMA/core: Fix uninitialized gid in ib_nl_process_good_ip_rsep() Kriish Sharma
2025-11-07 15:37 ` Jason Gunthorpe
2025-11-07 18:13 ` Kriish Sharma
2025-11-07 19:11 ` Vlad Dumitrescu
2025-11-07 19:17 ` Jason Gunthorpe [this message]
2025-11-07 19:58 ` Kriish Sharma
2025-11-07 21:06 ` Vlad Dumitrescu
2025-11-08 3:48 ` Kriish Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107191736.GC1859178@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=edwards@nvidia.com \
--cc=kriish.sharma2006@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=syzbot+938fcd548c303fe33c1a@syzkaller.appspotmail.com \
--cc=vdumitrescu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox