public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
Cc: jgg@nvidia.com, linux-rdma@vger.kernel.org, krzysztof.czurylo@intel.com
Subject: Re: [PATCH] RDMA/irdma: Fix data race in irdma_sc_ccq_arm
Date: Sun, 23 Nov 2025 10:41:44 +0200	[thread overview]
Message-ID: <20251123084144.GA16619@unreal> (raw)
In-Reply-To: <20251117210756.723-1-tatyana.e.nikolova@intel.com>

On Mon, Nov 17, 2025 at 03:07:49PM -0600, Tatyana Nikolova wrote:
> From: Krzysztof Czurylo <krzysztof.czurylo@intel.com>
> 
> - Adds a lock around irdma_sc_ccq_arm body to prevent inter-thread
>   data race.
> 
> - Fixes data race in irdma_sc_ccq_arm() reported by KCSAN:
> 
> BUG: KCSAN: data-race in irdma_sc_ccq_arm [irdma] / irdma_sc_ccq_arm [irdma]
> 
> read to 0xffff9d51b4034220 of 8 bytes by task 255 on cpu 11:
>  irdma_sc_ccq_arm+0x36/0xd0 [irdma]
>  irdma_cqp_ce_handler+0x300/0x310 [irdma]
>  cqp_compl_worker+0x2a/0x40 [irdma]
>  process_one_work+0x402/0x7e0
>  worker_thread+0xb3/0x6d0
>  kthread+0x178/0x1a0
>  ret_from_fork+0x2c/0x50
> 
> write to 0xffff9d51b4034220 of 8 bytes by task 89 on cpu 3:
>  irdma_sc_ccq_arm+0x7e/0xd0 [irdma]
>  irdma_cqp_ce_handler+0x300/0x310 [irdma]
>  irdma_wait_event+0xd4/0x3e0 [irdma]
>  irdma_handle_cqp_op+0xa5/0x220 [irdma]
>  irdma_hw_flush_wqes+0xb1/0x300 [irdma]
>  irdma_flush_wqes+0x22e/0x3a0 [irdma]
>  irdma_cm_disconn_true+0x4c7/0x5d0 [irdma]
>  irdma_disconnect_worker+0x35/0x50 [irdma]
>  process_one_work+0x402/0x7e0
>  worker_thread+0xb3/0x6d0
>  kthread+0x178/0x1a0
>  ret_from_fork+0x2c/0x50
> 
> value changed: 0x0000000000024000 -> 0x0000000000034000
> 
> Signed-off-by: Krzysztof Czurylo <krzysztof.czurylo@intel.com>
> Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
> ---
>  drivers/infiniband/hw/irdma/ctrl.c | 3 +++
>  1 file changed, 3 insertions(+)

Please add Fixes line to all these patches and send them as a series and
not as standalone patches with reply-to to some random patch as it is now.

Thanks

  parent reply	other threads:[~2025-11-23  8:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 21:07 [PATCH] RDMA/irdma: Fix data race in irdma_sc_ccq_arm Tatyana Nikolova
2025-11-17 21:07 ` [PATCH] RDMA/irdma: Fix data race in irdma_free_pble Tatyana Nikolova
2025-11-17 21:07 ` [PATCH] RDMA/irdma: Add a missing kfree of struct irdma_pci_f for GEN2 Tatyana Nikolova
2025-11-17 21:07 ` [PATCH] RDMA/irdma: Fix SIGBUS in AEQ destroy Tatyana Nikolova
2025-11-17 21:07 ` [PATCH] RDMA/irdma: Add missing mutex destroy Tatyana Nikolova
2025-11-17 21:07 ` [PATCH 1/2] RDMA/irdma: Do not directly rely on IB_PD_UNSAFE_GLOBAL_RKEY Tatyana Nikolova
2025-11-17 21:07 ` [PATCH 2/2] RDMA/irdma: Do not set IBK_LOCAL_DMA_LKEY for GEN3+ Tatyana Nikolova
2025-11-17 21:07 ` [PATCH] RDMA/irdma: Remove doorbell elision logic Tatyana Nikolova
2025-11-23  8:41 ` Leon Romanovsky [this message]
2025-11-25  0:01   ` [PATCH] RDMA/irdma: Fix data race in irdma_sc_ccq_arm Nikolova, Tatyana E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251123084144.GA16619@unreal \
    --to=leon@kernel.org \
    --cc=jgg@nvidia.com \
    --cc=krzysztof.czurylo@intel.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=tatyana.e.nikolova@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox