public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: "yanjun.zhu" <yanjun.zhu@linux.dev>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	Maher Sanalla <msanalla@nvidia.com>,
	Michael Guralnik <michaelgur@nvidia.com>
Subject: Re: [PATCH rdma-next 2/2] RDMA/mlx5: Add support for 1600_8x lane speed
Date: Sun, 23 Nov 2025 11:49:15 +0200	[thread overview]
Message-ID: <20251123094915.GC16619@unreal> (raw)
In-Reply-To: <3c2e6250-2451-41c3-a291-e7c5ae52ff62@linux.dev>

On Thu, Nov 20, 2025 at 02:44:20PM -0800, yanjun.zhu wrote:
> On 11/20/25 7:15 AM, Leon Romanovsky wrote:
> > From: Maher Sanalla <msanalla@nvidia.com>
> > 
> > Add a check for 1600G_8X link speed when querying PTYS and report it
> > back correctly when needed.
> 
> Amazing — 1600G is supported. I’m not sure whether this rate is supported
> only for InfiniBand or if it’s also available for RoCEv2. In any case,
> having such a high data rate is truly impressive.

It is both for InfiniBand and RoCE.

>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Thanks

> 
> Zhu Yanjun
> 
> > 
> > While at it, adjust mlx5 function which maps the speed rate from IB
> > spec values to internal driver values to be able to handle speeds
> > up to 1600Gbps.
> > 
> > Reviewed-by: Michael Guralnik <michaelgur@nvidia.com>
> > Signed-off-by: Maher Sanalla <msanalla@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> >   drivers/infiniband/hw/mlx5/main.c | 4 ++++
> >   drivers/infiniband/hw/mlx5/qp.c   | 5 +++--
> >   2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> > index 90daa58126f4..40284bbb45d6 100644
> > --- a/drivers/infiniband/hw/mlx5/main.c
> > +++ b/drivers/infiniband/hw/mlx5/main.c
> > @@ -511,6 +511,10 @@ static int translate_eth_ext_proto_oper(u32 eth_proto_oper, u16 *active_speed,
> >   		*active_width = IB_WIDTH_4X;
> >   		*active_speed = IB_SPEED_XDR;
> >   		break;
> > +	case MLX5E_PROT_MASK(MLX5E_1600TAUI_8_1600TBASE_CR8_KR8):
> > +		*active_width = IB_WIDTH_8X;
> > +		*active_speed = IB_SPEED_XDR;
> > +		break;
> >   	default:
> >   		return -EINVAL;
> >   	}
> > diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> > index 88724d15705d..69af20790481 100644
> > --- a/drivers/infiniband/hw/mlx5/qp.c
> > +++ b/drivers/infiniband/hw/mlx5/qp.c
> > @@ -3451,10 +3451,11 @@ int mlx5r_ib_rate(struct mlx5_ib_dev *dev, u8 rate)
> >   {
> >   	u32 stat_rate_support;
> > -	if (rate == IB_RATE_PORT_CURRENT || rate == IB_RATE_800_GBPS)
> > +	if (rate == IB_RATE_PORT_CURRENT || rate == IB_RATE_800_GBPS ||
> > +	    rate == IB_RATE_1600_GBPS)
> >   		return 0;
> > -	if (rate < IB_RATE_2_5_GBPS || rate > IB_RATE_800_GBPS)
> > +	if (rate < IB_RATE_2_5_GBPS || rate > IB_RATE_1600_GBPS)
> >   		return -EINVAL;
> >   	stat_rate_support = MLX5_CAP_GEN(dev->mdev, stat_rate_support);
> > 
> 
> 

  reply	other threads:[~2025-11-23  9:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 15:15 [PATCH rdma-next 0/2] Add new IB rate for XDR (8x) support Leon Romanovsky
2025-11-20 15:15 ` [PATCH rdma-next 1/2] RDMA/core: " Leon Romanovsky
2025-11-21  3:46   ` Kalesh Anakkur Purayil
2025-11-20 15:15 ` [PATCH rdma-next 2/2] RDMA/mlx5: Add support for 1600_8x lane speed Leon Romanovsky
2025-11-20 22:44   ` yanjun.zhu
2025-11-23  9:49     ` Leon Romanovsky [this message]
2025-11-21  3:47   ` Kalesh Anakkur Purayil
2025-11-23  9:53 ` [PATCH rdma-next 0/2] Add new IB rate for XDR (8x) support Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251123094915.GC16619@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=michaelgur@nvidia.com \
    --cc=msanalla@nvidia.com \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox