From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Margolin <mrgolin@amazon.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, sleybo@amazon.com,
matua@amazon.com, gal.pressman@linux.dev,
Tom Sela <tomsela@amazon.com>,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH] RDMA/efa: Remove possible negative shift
Date: Wed, 17 Dec 2025 14:04:25 -0400 [thread overview]
Message-ID: <20251217180425.GD211693@nvidia.com> (raw)
In-Reply-To: <20251210173656.8180-1-mrgolin@amazon.com>
On Wed, Dec 10, 2025 at 05:36:56PM +0000, Michael Margolin wrote:
> The page size used for device might in some cases be smaller than
> PAGE_SIZE what results in a negative shift when calculating the number
> of host pages in PAGE_SIZE for a debug log. Remove the debug line
> together with the calculation.
>
> Reviewed-by: Tom Sela <tomsela@amazon.com>
> Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
> Signed-off-by: Michael Margolin <mrgolin@amazon.com>
> Reviewed-by: Gal Pressman <gal.pressman@linux.dev>
> ---
> drivers/infiniband/hw/efa/efa_verbs.c | 4 ----
> 1 file changed, 4 deletions(-)
I added
Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")
Jason
prev parent reply other threads:[~2025-12-17 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 17:36 [PATCH] RDMA/efa: Remove possible negative shift Michael Margolin
2025-12-10 18:00 ` Gal Pressman
2025-12-17 18:04 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217180425.GD211693@nvidia.com \
--to=jgg@nvidia.com \
--cc=gal.pressman@linux.dev \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=tomsela@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).