From: Jason Gunthorpe <jgg@nvidia.com>
To: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
andrew.gospodarek@broadcom.com, selvin.xavier@broadcom.com,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH rdma-next v5 3/4] RDMA/bnxt_re: Direct Verbs: Support DBR verbs
Date: Wed, 17 Dec 2025 15:31:06 -0400 [thread overview]
Message-ID: <20251217193106.GA243690@nvidia.com> (raw)
In-Reply-To: <20251129165441.75274-4-sriharsha.basavapatna@broadcom.com>
On Sat, Nov 29, 2025 at 10:24:40PM +0530, Sriharsha Basavapatna wrote:
> +struct bnxt_re_dv_db_region {
> + __u32 dbr_handle;
> + __u32 dpi;
> + __u64 umdbr;
__aligned_u64
> + void *dbr;
void * cannot appear in the uapi headers, this has to be __aligned_u64
> + __aligned_u64 comp_mask;
We generally don't have comp_mask in these sorts of structs and it is
never used, remove it.
It looks like it only sets umdbr and dpi, so what the other things
even for? Remove them if they are not used.
Jason
next prev parent reply other threads:[~2025-12-17 21:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 16:54 [PATCH rdma-next v5 0/4] RDMA/bnxt_re: Support direct verbs Sriharsha Basavapatna
2025-11-29 16:54 ` [PATCH rdma-next v5 1/4] RDMA/bnxt_re: Move the UAPI methods to a dedicated file Sriharsha Basavapatna
2025-11-29 16:54 ` [PATCH rdma-next v5 2/4] RDMA/bnxt_re: Refactor bnxt_qplib_create_qp() function Sriharsha Basavapatna
2025-11-29 16:54 ` [PATCH rdma-next v5 3/4] RDMA/bnxt_re: Direct Verbs: Support DBR verbs Sriharsha Basavapatna
2025-12-17 19:31 ` Jason Gunthorpe [this message]
2025-12-24 4:37 ` Sriharsha Basavapatna
2025-12-17 19:58 ` Jason Gunthorpe
2025-12-24 4:38 ` Sriharsha Basavapatna
2025-12-17 22:33 ` Jason Gunthorpe
2025-12-24 4:39 ` Sriharsha Basavapatna
2025-11-29 16:54 ` [PATCH rdma-next v5 4/4] RDMA/bnxt_re: Direct Verbs: Support CQ and QP verbs Sriharsha Basavapatna
2025-12-17 22:36 ` Jason Gunthorpe
2025-12-24 4:39 ` Sriharsha Basavapatna
2025-12-18 1:46 ` Jason Gunthorpe
2025-12-24 4:41 ` Sriharsha Basavapatna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217193106.GA243690@nvidia.com \
--to=jgg@nvidia.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox