From: Leon Romanovsky <leon@kernel.org>
To: Md Haris Iqbal <haris.iqbal@ionos.com>
Cc: linux-rdma@vger.kernel.org, bvanassche@acm.org, jgg@ziepe.ca,
jinpu.wang@ionos.com, grzegorz.prajsner@ionos.com,
Kim Zhu <zhu.yanjun@ionos.com>
Subject: Re: [PATCH 2/9] RDMA/rtrs: Add error description to the logs
Date: Thu, 18 Dec 2025 17:51:29 +0200 [thread overview]
Message-ID: <20251218155129.GB400630@unreal> (raw)
In-Reply-To: <20251208161513.127049-3-haris.iqbal@ionos.com>
On Mon, Dec 08, 2025 at 05:15:06PM +0100, Md Haris Iqbal wrote:
> From: Kim Zhu <zhu.yanjun@ionos.com>
>
> Print error description besides the error number.
>
> Signed-off-by: Kim Zhu <zhu.yanjun@ionos.com>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c | 8 +-
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 89 ++++++++++----------
> drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c | 12 +--
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 78 ++++++++---------
> drivers/infiniband/ulp/rtrs/rtrs.c | 9 +-
> 5 files changed, 101 insertions(+), 95 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> index 4aa80c9388f0..b318acc12b10 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c
> @@ -439,19 +439,19 @@ int rtrs_clt_create_path_files(struct rtrs_clt_path *clt_path)
> clt->kobj_paths,
> "%s", str);
> if (err) {
> - pr_err("kobject_init_and_add: %d\n", err);
> + pr_err("kobject_init_and_add: %d(%pe)\n", err, ERR_PTR(err));
Or print error or print error description, not both.
Thanks
next prev parent reply other threads:[~2025-12-18 15:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 16:15 [PATCH 0/9] Misc patches for RTRS Md Haris Iqbal
2025-12-08 16:15 ` [PATCH 1/9] RDMA/rtrs-srv: fix SG mapping Md Haris Iqbal
2025-12-08 16:15 ` [PATCH 2/9] RDMA/rtrs: Add error description to the logs Md Haris Iqbal
2025-12-12 5:26 ` Dan Carpenter
2026-01-06 9:47 ` Haris Iqbal
2025-12-18 15:51 ` Leon Romanovsky [this message]
2026-01-06 10:03 ` Haris Iqbal
2025-12-08 16:15 ` [PATCH 3/9] RDMA/rtrs: Add optional support for IB_MR_TYPE_SG_GAPS Md Haris Iqbal
2025-12-09 1:12 ` Honggang LI
2026-01-06 9:28 ` Haris Iqbal
2025-12-08 16:15 ` [PATCH 4/9] RDMA/rtrs: Improve error logging for RDMA cm events Md Haris Iqbal
2025-12-08 16:15 ` [PATCH 5/9] RDMA/rtrs-clt: Remove unused list-head in rtrs_clt_io_req Md Haris Iqbal
2025-12-09 1:14 ` Honggang LI
2026-01-06 9:26 ` Haris Iqbal
2025-12-08 16:15 ` [PATCH 6/9] RDMA/rtrs-srv: Add check and closure for possible zombie paths Md Haris Iqbal
2025-12-09 1:17 ` Honggang LI
2026-01-06 9:27 ` Haris Iqbal
2025-12-08 16:15 ` [PATCH 7/9] RDMA/rtrs-srv: Rate-limit I/O path error logging Md Haris Iqbal
2025-12-08 16:15 ` [PATCH 8/9] RDMA/rtrs: Extend log message when a port fails Md Haris Iqbal
2025-12-08 16:15 ` [PATCH 9/9] RDMA/rtrs-clt.c: For conn rejection use actual err number Md Haris Iqbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251218155129.GB400630@unreal \
--to=leon@kernel.org \
--cc=bvanassche@acm.org \
--cc=grzegorz.prajsner@ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=linux-rdma@vger.kernel.org \
--cc=zhu.yanjun@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox