Re: [PATCH] RDMA/bnxt_re: Fix IB_SEND_IP_CSUM handling in post_send

[Leon Romanovsky <leon@kernel.org>]

On Fri, Dec 19, 2025 at 01:32:57AM -0800, Alok Tiwari wrote:
> The bnxt_re SEND path checks wr->send_flags to enable features such as
> IP checksum offload. However, send_flags is a bitmask and may contain
> multiple flags (e.g. IB_SEND_SIGNALED | IB_SEND_IP_CSUM), while the
> existing code uses a switch() statement that only matches when
> send_flags is exactly IB_SEND_IP_CSUM.
> 
> As a result, checksum offload is not enabled when additional SEND
> flags are present.
> 
> Replace the switch() with a bitmask test:
> 
>     if (wr->send_flags & IB_SEND_IP_CSUM)
> 
> This ensures IP checksum offload is enabled correctly when multiple
> SEND flags are used.
> 
> Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index f19b55c13d58..ff91511bd338 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -2919,14 +2919,9 @@ int bnxt_re_post_send(struct ib_qp *ib_qp, const struct ib_send_wr *wr,
>  				wqe.rawqp1.lflags |=
>  					SQ_SEND_RAWETH_QP1_LFLAGS_ROCE_CRC;
>  			}
> -			switch (wr->send_flags) {
> -			case IB_SEND_IP_CSUM:
> +			if (wr->send_flags & IB_SEND_IP_CSUM)
>  				wqe.rawqp1.lflags |=
>  					SQ_SEND_RAWETH_QP1_LFLAGS_IP_CHKSUM;
> -				break;

> -			default:
> -				break;
> -			}
>  			fallthrough;

The combination of "default with break" and "fallthrough" doesn't make
any sense. Are you sure that we should keep "fallthrough"?

Thanks

>  		case IB_WR_SEND_WITH_INV:
>  			rc = bnxt_re_build_send_wqe(qp, wr, &wqe);
> -- 
> 2.50.1
>