From: Jakub Kicinski <kuba@kernel.org>
To: Dipayaan Roy <dipayanroy@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, longli@microsoft.com,
kotaranov@microsoft.com, horms@kernel.org,
shradhagupta@linux.microsoft.com, ssengar@linux.microsoft.com,
ernis@linux.microsoft.com, shirazsaleem@microsoft.com,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
dipayanroy@microsoft.com
Subject: Re: [PATCH net-next, v6] net: mana: Implement ndo_tx_timeout and serialize queue resets per port.
Date: Mon, 5 Jan 2026 17:30:56 -0800 [thread overview]
Message-ID: <20260105173056.7c2c9d0a@kernel.org> (raw)
In-Reply-To: <20260103045705.GA3757@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Fri, 2 Jan 2026 20:57:05 -0800 Dipayaan Roy wrote:
> + apc = netdev_priv(ndev);
> + disable_work_sync(&apc->queue_reset_work.work);
AI code review points out:
In mana_remove(), disable_work_sync() is called for each port's
queue_reset_work. However, when resuming=true, mana_probe() creates a new
workqueue but does not call mana_probe_port() (which contains INIT_WORK),
and there is no enable_work() call for queue_reset_work in the resume path.
The existing link_change_work handles this correctly: it is disabled in
mana_remove() and re-enabled with enable_work(&ac->link_change_work) in
mana_probe() when resuming=true.
Should enable_work(&apc->queue_reset_work.work) be called for each port in
the resuming path of mana_probe(), similar to how link_change_work is
handled? Otherwise TX timeout recovery appears to remain disabled after a
suspend/resume cycle.
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-06 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 4:57 [PATCH net-next, v6] net: mana: Implement ndo_tx_timeout and serialize queue resets per port Dipayaan Roy
2026-01-06 1:30 ` Jakub Kicinski [this message]
2026-01-06 22:59 ` Dipayaan Roy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105173056.7c2c9d0a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=dipayanroy@linux.microsoft.com \
--cc=dipayanroy@microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=kotaranov@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shirazsaleem@microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox