Re: [PATCH] RDMA/bng_re: Unwind bng_re_dev_init properly and remove unnecessary rdev check

[Leon Romanovsky <leon@kernel.org>]

On Mon, Jan 12, 2026 at 02:44:05PM +0530, Siva Reddy Kallam wrote:
> On Sun, Jan 11, 2026 at 6:53 PM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Wed, Jan 07, 2026 at 09:16:07AM +0000, Siva Reddy Kallam wrote:
> > > Fix below smatch warnings:
> > > drivers/infiniband/hw/bng_re/bng_dev.c:113
> > > bng_re_net_ring_free() warn: variable dereferenced before check 'rdev'
> > > (see line 107)
> > > drivers/infiniband/hw/bng_re/bng_dev.c:270
> > > bng_re_dev_init() warn: missing unwind goto?
> >
> > Please provide commit message.
> Sure, will do in next version of patch.
> >
> > >
> > > Fixes: 4f830cd8d7fe ("RDMA/bng_re: Add infrastructure for enabling Firmware channel")
> > > Reported-by: Simon Horman <horms@kernel.org>
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Reported-by: Dan Carpenter <error27@gmail.com>
> > > Closes: https://lore.kernel.org/r/202601010413.sWadrQel-lkp@intel.com/
> > > Signed-off-by: Siva Reddy Kallam <siva.kallam@broadcom.com>
> > > Reviewed-by: Usman Ansari <usman.ansari@broadcom.com>
> > > ---
> > >  drivers/infiniband/hw/bng_re/bng_dev.c | 33 +++++++++++++-------------
> > >  1 file changed, 16 insertions(+), 17 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/bng_re/bng_dev.c b/drivers/infiniband/hw/bng_re/bng_dev.c
> > > index d8f8d7f7075f..e2dd2c8eb6d2 100644
> > > --- a/drivers/infiniband/hw/bng_re/bng_dev.c
> > > +++ b/drivers/infiniband/hw/bng_re/bng_dev.c
> > > @@ -124,9 +124,6 @@ static int bng_re_net_ring_free(struct bng_re_dev *rdev,
> > >       struct bnge_fw_msg fw_msg = {};
> > >       int rc = -EINVAL;
> > >
> > > -     if (!rdev)
> >
> > You have other places with impossible "if (rdev)" check in this path which you should
> > delete as well.
> Hi Leon,
> I see only one "if (rdev)" in bng_re_remove . Are you referring to that?

Yes, this is the place I noticed as well, but I would welcome a more
general cleanup.

Thanks