Re: [PATCH v1 1/4] RDMA/core: add bio_vec based RDMA read/write API

[Leon Romanovsky <leon@kernel.org>]

On Fri, Jan 16, 2026 at 09:57:57AM -0500, Chuck Lever wrote:
> 
> 
> On Fri, Jan 16, 2026, at 9:52 AM, Christoph Hellwig wrote:
> > On Fri, Jan 16, 2026 at 01:33:10PM +0200, Leon Romanovsky wrote:
> >> > Much of this seems to duplicate rdma_rw_init_map_wrs.  I wonder if
> >> > having a low-level helper that gets either a scatterlist or bvec array
> >> > (or bvec_iter) and just has different inner loops for them would
> >> > make more sense?  If not we'll just need to migrate everyone off
> >> > the scatterlist version ASAP :)
> >> 
> >> I had short offline discussion with Jason about this series and both of
> >> us would be more than happy to get rid of "scatterlist version".
> >
> > nvmet_rdma_rw_ctx_init is used by isert, srpt, nvmet, ksmbd and
> > the sunrpc server side.  I don't think any of them should be
> > super complicated to work, but it will need a fair amount of testing
> > resources.
> 
> My preference is to keep the scope of this series narrow --
> introduce the new API, and add one consumer for it. The other
> conversions can then each be done by domain experts as they
> have time.

Of course, I'm only outlining the direction in which the RDMA subsystem
is expected to evolve.

> 
> I have no strong feeling for or against eventually removing
> SGL support entirely from rw.c.
> 
> -- 
> Chuck Lever