Re: [PATCH v1 1/4] RDMA/core: add bio_vec based RDMA read/write API

[Leon Romanovsky <leon@kernel.org>]

On Fri, Jan 16, 2026 at 04:49:06PM -0500, Chuck Lever wrote:
> 
> 
> On Fri, Jan 16, 2026, at 4:24 PM, Leon Romanovsky wrote:
> > On Thu, Jan 15, 2026 at 04:53:34PM +0100, Christoph Hellwig wrote:
> >> > +static int rdma_rw_init_single_wr_bvec(struct rdma_rw_ctx *ctx,
> >> > +		struct ib_qp *qp, const struct bio_vec *bvec, u32 offset,
> >> > +		u64 remote_addr, u32 rkey, enum dma_data_direction dir)
> >> > +{
> >> > +	struct ib_device *dev = qp->pd->device;
> >> > +	struct ib_rdma_wr *rdma_wr = &ctx->single.wr;
> >> > +	struct bio_vec adjusted = *bvec;
> >> > +	u64 dma_addr;
> >> > +
> >> > +	ctx->nr_ops = 1;
> >> > +
> >> > +	if (offset) {
> >> > +		adjusted.bv_offset += offset;
> >> > +		adjusted.bv_len -= offset;
> >> > +	}
> >> 
> >> Hmm, if we need to split/adjust bvecs, it might be better to
> >> pass a bvec_iter and let the iter handle the iteration?
> >
> > It would also be worthwhile to support P2P scenarios in this flow.
> 
> I can add some code to this series to do that, but I don't believe
> I have facilities to test it.

If it is possible, let's add.

Thanks

> 
> -- 
> Chuck Lever