Re: [PATCH rdma-rext 0/4] RDMA/bnxt_re: Add QP rate limit support

[Leon Romanovsky <leon@kernel.org>]

On Sun, Jan 25, 2026 at 09:47:05AM +0530, Kalesh Anakkur Purayil wrote:
> Hi Leon, Jason,
> 
> A gentle reminder. Could you please review the patch series?

Sorry for the delayed response. The idea and implementation look fine to me.
What is missing is a clear and well-documented definition of the semantics
of QP rate limiting for RC QPs.

How should RDMA_READ or small RDMA_REQ packets be treated? Are response
packets included in the rate limit as well? It must be documented in
man pages.

Thanks

> 
> On Fri, Jan 16, 2026 at 2:43 PM Kalesh AP
> <kalesh-anakkur.purayil@broadcom.com> wrote:
> >
> > Hi,
> >
> > This patchset supports QP rate limit in the bnxt_re driver.
> >
> > Broadcom P7 devices supports setting the rate limit while changing
> > RC QP state from INIT to RTR, RTR to RTS and RTS to RTS. Or, once
> > the QP is transitioned to RTR or RTS state.
> >
> > First patch adds stack support for rate limit for RC QPs.
> >
> > Second patch adds support for QP rate limiting in the bnxt_re driver.
> >
> > Third patch adds support to report packet pacing capabilities in the
> > query_device.
> >
> > Forth patch adds support to report QP rate limit in debugfs QP info.
> >
> > The pull request for rdma-core changes are at:
> >
> > https://github.com/linux-rdma/rdma-core/pull/1692
> >
> > Regards,
> > Kalesh
> >
> > Kalesh AP (4):
> >   IB/core: Extend rate limit support for RC QPs
> >   RDMA/bnxt_re: Add support for QP rate limiting
> >   RDMA/bnxt_re: Report packet pacing capabilities when querying device
> >   RDMA/bnxt_re: Report QP rate limit in debugfs
> >
> >  drivers/infiniband/core/verbs.c           |  9 ++++--
> >  drivers/infiniband/hw/bnxt_re/debugfs.c   | 14 ++++++--
> >  drivers/infiniband/hw/bnxt_re/ib_verbs.c  | 39 +++++++++++++++++++++--
> >  drivers/infiniband/hw/bnxt_re/qplib_fp.c  | 12 ++++++-
> >  drivers/infiniband/hw/bnxt_re/qplib_fp.h  |  3 ++
> >  drivers/infiniband/hw/bnxt_re/qplib_res.h |  6 ++++
> >  drivers/infiniband/hw/bnxt_re/qplib_sp.c  |  5 +++
> >  drivers/infiniband/hw/bnxt_re/qplib_sp.h  |  2 ++
> >  drivers/infiniband/hw/bnxt_re/roce_hsi.h  | 13 +++++---
> >  include/uapi/rdma/bnxt_re-abi.h           | 16 ++++++++++
> >  10 files changed, 107 insertions(+), 12 deletions(-)
> >
> > --
> > 2.43.5
> >
> 
> 
> -- 
> Regards,
> Kalesh AP