From: Christoph Hellwig <hch@lst.de>
To: Chuck Lever <cel@kernel.org>
Cc: Leon Romanovsky <leon@kernel.org>, Christoph Hellwig <hch@lst.de>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v4 3/5] RDMA/core: add MR support for bvec-based RDMA operations
Date: Tue, 27 Jan 2026 06:42:35 +0100 [thread overview]
Message-ID: <20260127054235.GB24998@lst.de> (raw)
In-Reply-To: <20260126181414.105062-4-cel@kernel.org>
> + struct {
> + struct rdma_rw_reg_ctx {
> + struct ib_sge sge;
> + struct ib_rdma_wr wr;
> + struct ib_reg_wr reg_wr;
> + struct ib_send_wr inv_wr;
> + struct ib_mr *mr;
> + } *ctx;
> + struct sg_table sgt;
> + } reg;
I still don't understand why the sgt is not in
struct rdma_rw_reg_ctx. Right now that is allocate a little bit
later than the sgt initialization and freed a tiny bit to early,
but that seems to be easy to fix.
Doing so would reduce the memory usage for the common non-registration
path, and significantly reduce the churn in the patch.
next prev parent reply other threads:[~2026-01-27 5:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 18:14 [PATCH v4 0/5] Add a bio_vec based API to core/rw.c Chuck Lever
2026-01-26 18:14 ` [PATCH v4 1/5] RDMA/core: add bio_vec based RDMA read/write API Chuck Lever
2026-01-26 18:14 ` [PATCH v4 2/5] RDMA/core: use IOVA-based DMA mapping for bvec RDMA operations Chuck Lever
2026-01-27 5:38 ` Christoph Hellwig
2026-01-26 18:14 ` [PATCH v4 3/5] RDMA/core: add MR support for bvec-based " Chuck Lever
2026-01-27 5:42 ` Christoph Hellwig [this message]
2026-01-26 18:14 ` [PATCH v4 4/5] RDMA/core: add rdma_rw_max_sge() helper for SQ sizing Chuck Lever
2026-01-26 18:14 ` [PATCH v4 5/5] svcrdma: use bvec-based RDMA read/write API Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127054235.GB24998@lst.de \
--to=hch@lst.de \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox