From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
leon@kernel.org, linux-rdma@vger.kernel.org,
andrew.gospodarek@broadcom.com, selvin.xavier@broadcom.com,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH rdma-next v9 4/5] RDMA/bnxt_re: Direct Verbs: Support DBR verbs
Date: Tue, 27 Jan 2026 11:56:03 -0400 [thread overview]
Message-ID: <20260127155603.GF1641016@ziepe.ca> (raw)
In-Reply-To: <qkqqa6grjmfbkxalfk25w2gliscr3e4erdwae4zvl2oqncwgyn@brkp7gu3ppy6>
On Tue, Jan 27, 2026 at 04:07:41PM +0100, Jiri Pirko wrote:
> Tue, Jan 27, 2026 at 03:15:45PM +0100, jgg@ziepe.ca wrote:
> >On Tue, Jan 27, 2026 at 01:30:03PM +0100, Jiri Pirko wrote:
> >> Tue, Jan 27, 2026 at 11:31:08AM +0100, sriharsha.basavapatna@broadcom.com wrote:
> >> >From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> >> >
> >> >The following Direct Verbs (DV) methods have been implemented in
> >> >this patch.
> >> >
> >> >Doorbell Region Direct Verbs:
> >> >-----------------------------
> >> >- BNXT_RE_METHOD_DBR_ALLOC:
> >> > This will allow the appliation to create extra doorbell regions
> >> > and use the associated doorbell page index in DV_CREATE_QP and
> >> > use the associated DB address while ringing the doorbell.
> >> >
> >> >- BNXT_RE_METHOD_DBR_FREE:
> >> > Free the allocated doorbell region.
> >> >
> >> >- BNXT_RE_METHOD_GET_DEFAULT_DBR:
> >> > Return the default doorbell page index and doorbell page address
> >> > associated with the ucontext.
> >> >
> >>
> >> Similar to CQ/QP, why this is bnxt specific? I know a little about rdma,
> >> but I believe we use it in mlx5 too, no?
> >
> >mlx5 has a specific thing too, the doorbell has enough fairly hw
> >specific properties and never leaks outside the userspace provider.
> >
> >We consolidated the internal code to manage the mmaps, beyond that
> >there hasn't been a big push to consolidate more.
>
> I'm a bit lost about what this patchset tries to do. The cover letter
> does not mention dmabuf at all. Not sure why. I understand that create
> cq/qp is enabled to work with user-passed dma-buf info. So that makes me
> assume the same for DBR. I guess I'm wrong.
This series doesn't really clearly explain what it is actually for,
but it is almost certianly about supporting what NCCL calls "GPU
Initiated Networking (GIN)".
To do this you need a couple of components:
1) "DV" verbs to allow direct access to the underlying HW queues
under a QP/CQ. This is because you will write a "RDMA provider"
that runs on the GPU
2) DMABUF support for QP/CQ because you will use DMABUF to place
the QP/CQ inside GPU VRAM so that the "RDMA provider" running in
the GPU can access the rings at full performance
3) A doorebell ring that is compatible with the GPU, usually meaning
dedicated doorbell registers because the GPU can't do locking
coordinated with the CPU.
Of course there are other ways to use these APIs and DV was first
invented for DPDK not NCCL..
Jason
next prev parent reply other threads:[~2026-01-27 15:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 10:31 [PATCH rdma-next v9 0/5] RDMA/bnxt_re: Support direct verbs Sriharsha Basavapatna
2026-01-27 10:31 ` [PATCH rdma-next v9 1/5] RDMA/uverbs: Support QP creation with user allocated memory Sriharsha Basavapatna
2026-01-27 12:12 ` Jiri Pirko
2026-01-27 13:04 ` Sriharsha Basavapatna
2026-01-28 10:16 ` Jiri Pirko
2026-01-28 12:31 ` Leon Romanovsky
2026-01-27 10:31 ` [PATCH rdma-next v9 2/5] RDMA/bnxt_re: Move the UAPI methods to a dedicated file Sriharsha Basavapatna
2026-01-27 10:31 ` [PATCH rdma-next v9 3/5] RDMA/bnxt_re: Refactor bnxt_qplib_create_qp() function Sriharsha Basavapatna
2026-01-27 10:31 ` [PATCH rdma-next v9 4/5] RDMA/bnxt_re: Direct Verbs: Support DBR verbs Sriharsha Basavapatna
2026-01-27 12:30 ` Jiri Pirko
2026-01-27 14:15 ` Jason Gunthorpe
2026-01-27 15:07 ` Jiri Pirko
2026-01-27 15:56 ` Jason Gunthorpe [this message]
2026-01-28 10:04 ` Jiri Pirko
2026-01-28 15:33 ` Jason Gunthorpe
2026-01-27 10:31 ` [PATCH rdma-next v9 5/5] RDMA/bnxt_re: Direct Verbs: Support CQ and QP verbs Sriharsha Basavapatna
2026-01-28 15:32 ` Jason Gunthorpe
2026-01-28 15:51 ` Jason Gunthorpe
2026-01-28 18:03 ` Sriharsha Basavapatna
2026-01-28 19:41 ` Jason Gunthorpe
2026-01-28 16:54 ` Sriharsha Basavapatna
2026-01-28 17:57 ` Sriharsha Basavapatna
2026-01-28 19:42 ` Jason Gunthorpe
2026-02-02 14:19 ` Sriharsha Basavapatna
2026-02-02 17:48 ` Jason Gunthorpe
2026-02-03 5:05 ` Sriharsha Basavapatna
2026-02-03 8:57 ` Jiri Pirko
2026-01-28 17:58 ` Jason Gunthorpe
2026-01-28 15:46 ` Jason Gunthorpe
2026-02-02 14:19 ` Sriharsha Basavapatna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127155603.GF1641016@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=andrew.gospodarek@broadcom.com \
--cc=jiri@resnulli.us \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox