public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>,
	linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH rdma-rext 0/4] RDMA/bnxt_re: Add QP rate limit support
Date: Wed, 28 Jan 2026 20:40:38 -0400	[thread overview]
Message-ID: <20260129004038.GA1641016@ziepe.ca> (raw)
In-Reply-To: <CA+sbYW3dLsVqXcaG9xYdh-YRpdf6-ZjrMKRCBnapMY+gFzoA2w@mail.gmail.com>

On Wed, Jan 28, 2026 at 12:33:57PM +0530, Selvin Xavier wrote:

> We have another question. Existing implementation of IB_QP_RATE_LIMIT
> is applicable only for raw ethernet QP. With this change, we will
> start supporting for RC QPs also. So mlx driver can also get this
> request for RC QPs, but it will silently ignored as the QP type is not
> Raw ethernet QP. Should we fail the request instead?

Yes it should fail, I think that is an existing mlx5 bug

Jason

  parent reply	other threads:[~2026-01-29  0:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16  9:18 [PATCH rdma-rext 0/4] RDMA/bnxt_re: Add QP rate limit support Kalesh AP
2026-01-16  9:18 ` [PATCH rdma-rext 1/4] IB/core: Extend rate limit support for RC QPs Kalesh AP
2026-01-16  9:18 ` [PATCH rdma-rext 2/4] RDMA/bnxt_re: Add support for QP rate limiting Kalesh AP
2026-01-16  9:18 ` [PATCH rdma-rext 3/4] RDMA/bnxt_re: Report packet pacing capabilities when querying device Kalesh AP
2026-01-16  9:18 ` [PATCH rdma-rext 4/4] RDMA/bnxt_re: Report QP rate limit in debugfs Kalesh AP
2026-01-25  4:17 ` [PATCH rdma-rext 0/4] RDMA/bnxt_re: Add QP rate limit support Kalesh Anakkur Purayil
2026-01-26 20:18   ` Leon Romanovsky
2026-01-28  7:03     ` Selvin Xavier
2026-01-28 12:17       ` Leon Romanovsky
2026-01-29  5:31         ` Selvin Xavier
2026-01-29  0:40       ` Jason Gunthorpe [this message]
2026-01-29  5:24         ` Selvin Xavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129004038.GA1641016@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=selvin.xavier@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox