From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6B02134CF for ; Fri, 30 Jan 2026 13:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769781382; cv=none; b=plOAfbS+++gb4w6VZr2tUue3jhIfaji65xge0WNJWEY6FApe+YkKygAqOwuQcYYJcwMjgzGiUXsEMvVdt5xIuI20LalXJsx0O7IKCyWrnhzAZp2qzyDtWXwfk9xfZ/s76us8xPxcpBNP8eI5QAmMul1p+Oke1PTU7pwnfh/xcmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769781382; c=relaxed/simple; bh=SL16M++KtfIb+4uJE+a/R7kOylXhnM5j4tZGOMk8fro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qmMcXxlNij2wMang2+J/SXiGgllIhPTXLiyppaJ9guRgJFlkDFwOTkdeGu+hj4Nnc+nTQ7U1fbTU78FgPkjHBLvhBdUEXVijeq3m+dROJkEk4pTCG9bttzW3hATyZxrZ7i22AmLj0vbIWi1m5Soha2jNT5Bw3fTM5qlPCivs4/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=eIYcXAWS; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="eIYcXAWS" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-894638da330so21340606d6.1 for ; Fri, 30 Jan 2026 05:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1769781379; x=1770386179; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nHaCd4HrbYw78ScpRIoaj6AeaBJaVtnx8urFDLScj1Y=; b=eIYcXAWSoo1RbCh5BvSxy6AEZnoiozLBx1VBEN2IWQi8ZC19oyIWOOVmRnZzJF+1Yk SCC/pCL3wp5JE8KWke6ThiaLJnoP1be7LSDKGW24XvZ5Kn+ozIGNhbOhK/olKYWEHD2u uSe+TCKw4TcbIHEYVz4MZIlSHAcwYGMub7mqUUEn3ZYEjOyamT+dTcZCo5KOg8J9d6sw ANgcr5CV39slNHFiDZTsXt8wUcpjwcDmngp47QEGfM5rWOW/2zbuqcrvmM22lo8AwwHE 4FunVydn1CLvLnxp1o/5Oz9rFQSCnwmeedSXMFIuXAXZS6xG8M2dhjxa5VrLVJI2FSo2 hGew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769781379; x=1770386179; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nHaCd4HrbYw78ScpRIoaj6AeaBJaVtnx8urFDLScj1Y=; b=Wl9d4FrLscNRWzWBCbqHbrVvhx6BMx9fgkY4bCOZo/8DE4TnWh2ui5CyxDQWUKPGMH kK4tSwkuS/WUk5Z+wM7Zba3x1ewPxBo/ZaIU3olYBxr5BnNgCY8wD/6JFLLkbuXFrqJy l0bZYC+QH8w1EH0+q3IMGx717FKcVMLVUwsaQRIUU+oN8M7UWlb6NKDGFftClAAC0v3A vIy4xApeRjdk4bJgl/53yDtFP/Zx/uAAPYSupl7ZMGf5U4DzGGYAtSnvB5plnEeE9VUb 0Jm1nvd66HVWUC4aQhLhfoINpDCZ3yEZzx5oyhoR3pUs8YCQUMa9z3zQJs+cKIVeMfsF U4rw== X-Forwarded-Encrypted: i=1; AJvYcCWh0SvnNL9BNfJC15dBzu7b8aEMARo9dW3rBHApBOmJEq9z5jUyKr1KGvhufdxckTB13hif2RC/4Dgb@vger.kernel.org X-Gm-Message-State: AOJu0YyWQr6E9Bd3QE0FPplf9PtNaUJnzLwLObRzMbzFCOGmRp+1K3KB u9KMAJLJSV+tYUhJ6d6i0RWOzCf4A9/9FyWvbnLGOMOVORdzSno9qLBjFzAsOYceO/I= X-Gm-Gg: AZuq6aJ7UQgfM9ueuRM5LCZ6c7jsEpDbMP7MPcOwQvBtHwBPGocsmNQjpHwrOq+DPaT N5aS6yjy9DRWXC8th79+gzOvHAwc0lhGj8obGriDJJxALfvxpluSIMKWlxRqQUW2fwY/BNsQfL/ ephbUBlkUbFQtI+XlXTDNkulUgUAi7/pR8cvoTUSrg1Y2wwUdVH2LHIAW+BtPQCceoi+db3E4g8 HcAphyGC5/il3v8U8LTs24VPPl4zQX2NkcARC/hoiurJCU5UNEho/1bznXIyB2oWp4NSeM6Nirz CrZI03BtTCijTdtO+KwqPFOuQZkHcjFARp/OQSnS6sGDVwBlmxxf294oUB4JvrtMqIZJYNti3CR 26uOvt8XKshu38lKvHN8+f8vESUAXDhoW4yqKulqr4PsLaw+bzCSZtYARy3YXyAHLyjebo4Hmbc sajYEmoq5yscIQF2kbfI7bN0opB1leAZhXPSPls4DbjjeFMpVdD33SLoQYQo6eHuvTJd1rzQu+l w3RMw== X-Received: by 2002:a05:6214:2a48:b0:88a:529a:a53a with SMTP id 6a1803df08f44-894ea09691emr43666386d6.51.1769781379597; Fri, 30 Jan 2026 05:56:19 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-894d376da66sm59670316d6.50.2026.01.30.05.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 05:56:19 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vloyw-0000000AmRb-29H1; Fri, 30 Jan 2026 09:56:18 -0400 Date: Fri, 30 Jan 2026 09:56:18 -0400 From: Jason Gunthorpe To: Christian =?utf-8?B?S8O2bmln?= Cc: Leon Romanovsky , Sumit Semwal , Alex Deucher , David Airlie , Simona Vetter , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas De Marchi , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Rodrigo Vivi , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Felix Kuehling , Alex Williamson , Ankit Agrawal , Vivek Kasireddy , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org Subject: Re: [PATCH v5 4/8] vfio: Wait for dma-buf invalidation to complete Message-ID: <20260130135618.GC2328995@ziepe.ca> References: <20260124-dmabuf-revoke-v5-0-f98fca917e96@nvidia.com> <20260124-dmabuf-revoke-v5-4-f98fca917e96@nvidia.com> <31872c87-5cba-4081-8196-72cc839c6122@amd.com> <20260130130131.GO10992@unreal> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jan 30, 2026 at 02:21:08PM +0100, Christian König wrote: > That would work for me. > > Question is if you really want to do it this way? See usually > exporters try to avoid blocking such functions. Yes, it has to be this way, revoke is a synchronous user space triggered operation around things like FLR or device close. We can't defer it into some background operation like pm. > >>> } > >>> fput(priv->dmabuf->file); > >> > >> This is also extremely questionable. Why doesn't the dmabuf have > >> a reference while on the linked list? If we hold a refcount while on the list then the FD can never be closed. There is locking protecting the list so that it is safe and close continues to work right. Jason