From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E941A23E358 for ; Sat, 7 Feb 2026 01:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770426348; cv=none; b=XfqRUWcY6FbbZtX70lOL2131Bw6wUz+VKfroJ1atTrVpj4Fc/xnjSLYn40Bha+kHksogpzDlIm0tFGdXeFO9sG3s2YHYggay2mDNf/IWWoz/eTgercpvJNXujdNVim7znKm8YyUPSpivU/x8wxFEsD7lOIu+iP18suRDiB2liEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770426348; c=relaxed/simple; bh=bcCx6HvBn0+chH2BkVmgtrY08qINfxUdLSUwj8yhhhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qwE/CZ10lgwzGbMV5uAMhVFTYFDSJ6p5yGhpfk88Gf+6GIR7mR/i8sDhBGpy+Gy840kpNW2HmlDdJl9zpVZP//YT4ZT8jFfw4efh3dP2M+UFKZ6irt2RhnikBu5M0gvakCVoPxMOy4SEUQRFie3C5dIYJ0uWUpAKRfIgIRCqHkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RtDr9vkH; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RtDr9vkH" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-43624d7256bso1621207f8f.1 for ; Fri, 06 Feb 2026 17:05:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770426346; x=1771031146; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A6SIRr3fzUj0Hk1tRyParUBPPpIXg889DTrd52bS/88=; b=RtDr9vkHduqjyu2vfUGnB92UTSgwg9hbx6gTrU7te0cxbuFnkzFRTAFrntzP4OCKlz GacROgmu5unFIwYq+NVNxUhp59pxAnkI8tr4T/gnslBjqX/FGAhrHiPqRnFRW22aiRDB PQi6FuvLMIk52P5b+6tbmEVzYscBJlCFK6Wb8a3u9TtWosEnfOmfx8VI+vgEhTJsicxN lqnGj2UaF5fXIz14GD8H7wNFNKnmApZZwzgv0e8gFSkFtmmbupM1cSrxMucq5WmRWLht 3CgdvDuVlYhr0H38E2ViO7ehvktanMUi/eHH3pc91pAvfkzzKoCT5EYmcCiJKn8tasVF 1ATA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770426346; x=1771031146; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=A6SIRr3fzUj0Hk1tRyParUBPPpIXg889DTrd52bS/88=; b=YghePTiPrEMiYx4DS3F/Gd6za11sHHAloDcx1flfiPXLjvCV530JrvW/+7lYQ4aG1q Xx6+DRHuuaQIqXPjJ0Z8C0aIaKJ8hiHarMJHrWmmh4cVu9wVGPLe1N8BEtnPBgYljS0C 9Gbix0IshS5DF88Vzg6yJs4hJSBVhQvP0EzFiAg18g7ij2FE/KNygiwK1A6TnDL1IUp5 4ZWZKxvFcv4JixLabtWA7KlVdimCJlxo2udvVlcwUnh3QpYb/Du/we0KSfypq5zreaGh jDtY9pyO8vRQg3/KcRIpgjeTUxQPF7+FyxWvlkEBamC5Xc9BoKWhFuW7JvuAur9zd5WU zeEg== X-Forwarded-Encrypted: i=1; AJvYcCUMPdeMBAUUpa2LNzrd398/gAxm63eD9GyNeuDQqEDyquDC+Wi6LqNgoyyIWrLILtuNm3jeQP1vNomF@vger.kernel.org X-Gm-Message-State: AOJu0YxHYRIFZoW0b9r9WkZjs/uN4gU9LSKJMUhJ37Xggnn53v5RmWUS 09fan/BQDDQk05skCvqIeSA9NfN2kMZyWEiF2EbWx+zjl0pU9/aNgsj1 X-Gm-Gg: AZuq6aKWqDUmhEOkM06YpZTFs+wqkp+bgQs7up6V7CIo07CtYNK/+F3GsSpewDij5ff yt2yePz5pjxMYPcV8bIQrKuz6gu9+1ZFv3kjyj0Bg0bAtmYTk6M0t7Yek7A/g+B2Ahma4PpFCmB hObF+ZGZ4Z0OOzuBZj7LOLxigZgX46hnOBLBrI4xoP1uJI/eyWPmXNYxZWGREdMSreeeLO5U/EH BHua16qQ/NOKgcQInLYgB7SdrrKpFqW3RKjYfqh3WqtIyy/FXQc+yCsJ/bUsflhkCdNiZGw/9cU Hkk/bRhS6HZ+HymAkJ68EtsfLIImkwU/mgauMpTO007ikOWGEh7tzV7JLwRa6n+PUcjPSLihJrv 7MpwuEK+yfvA3B2zEL2FPZGRP8zwbj4gw4MwEvRi30q1EjvAQOSppNO3dVUxXWDDInXCQqd5pxh B9N7x78bU9 X-Received: by 2002:a05:6000:2411:b0:436:1946:c186 with SMTP id ffacd0b85a97d-4362933cb20mr6948634f8f.10.1770426346312; Fri, 06 Feb 2026 17:05:46 -0800 (PST) Received: from localhost ([2a03:2880:31ff:5f::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436297450b4sm9990741f8f.34.2026.02.06.17.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 17:05:45 -0800 (PST) From: Mohsin Bashir To: netdev@vger.kernel.org Cc: alexanderduyck@fb.com, andrew+netdev@lunn.ch, andrew@lunn.ch, davem@davemloft.net, donald.hunter@gmail.com, edumazet@google.com, gal@nvidia.com, horms@kernel.org, idosch@nvidia.com, jacob.e.keller@intel.com, kernel-team@meta.com, kory.maincent@bootlin.com, kuba@kernel.org, lee@trager.us, leon@kernel.org, linux-rdma@vger.kernel.org, linux@armlinux.org.uk, mbloch@nvidia.com, mohsin.bashr@gmail.com, o.rempel@pengutronix.de, pabeni@redhat.com, saeedm@nvidia.com, tariqt@nvidia.com, vadim.fedorenko@linux.dev Subject: [PATCH net-next V2 4/5] eth: fbnic: Fetch TX pause storm stats Date: Fri, 6 Feb 2026 17:05:24 -0800 Message-ID: <20260207010525.3808842-5-mohsin.bashr@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260207010525.3808842-1-mohsin.bashr@gmail.com> References: <20260207010525.3808842-1-mohsin.bashr@gmail.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With pause storm protection in place, track the occurrence of pause storm events. Since there is a one-to-one mapping between pause storm interrupts and events, use the interrupt count to track this metric. ./ethtool -I -a eth0 Pause parameters for eth0: Autonegotiate: off RX: off TX: on Statistics: tx_pause_frames: 759657 rx_pause_frames: 0 tx_pause_storm_events: 219 Signed-off-by: Jakub Kicinski Signed-off-by: Mohsin Bashir --- drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 1 + drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c | 3 +++ drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h | 1 + drivers/net/ethernet/meta/fbnic/fbnic_mac.c | 15 +++++++++++++++ 4 files changed, 20 insertions(+) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_csr.h b/drivers/net/ethernet/meta/fbnic/fbnic_csr.h index e68c56237b61..72eb22a52572 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_csr.h +++ b/drivers/net/ethernet/meta/fbnic/fbnic_csr.h @@ -627,6 +627,7 @@ enum { FBNIC_RXB_ENQUEUE_INDICES = 4 }; +#define FBNIC_RXB_INTR_PS_COUNT(n) (0x080e9 + (n)) /* 0x203a4 + 4*n */ #define FBNIC_RXB_DRBO_FRM_CNT_SRC(n) (0x080f9 + (n)) /* 0x203e4 + 4*n */ #define FBNIC_RXB_DRBO_BYTE_CNT_SRC_L(n) \ (0x080fd + (n)) /* 0x203f4 + 4*n */ diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c b/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c index dc57519ebbe5..15d3162ab186 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c @@ -1751,6 +1751,7 @@ fbnic_get_pause_stats(struct net_device *netdev, struct fbnic_net *fbn = netdev_priv(netdev); struct fbnic_mac_stats *mac_stats; struct fbnic_dev *fbd = fbn->fbd; + u64 tx_ps_events; mac_stats = &fbd->hw_stats.mac; @@ -1758,6 +1759,8 @@ fbnic_get_pause_stats(struct net_device *netdev, pause_stats->tx_pause_frames = mac_stats->pause.tx_pause_frames.value; pause_stats->rx_pause_frames = mac_stats->pause.rx_pause_frames.value; + tx_ps_events = mac_stats->pause.tx_pause_storm_events.value; + pause_stats->tx_pause_storm_events = tx_ps_events; } static void diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h b/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h index aa3f429a9aed..caea4be46762 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h +++ b/drivers/net/ethernet/meta/fbnic/fbnic_hw_stats.h @@ -54,6 +54,7 @@ struct fbnic_rmon_stats { struct fbnic_pause_stats { struct fbnic_stat_counter tx_pause_frames; struct fbnic_stat_counter rx_pause_frames; + struct fbnic_stat_counter tx_pause_storm_events; }; struct fbnic_eth_mac_stats { diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_mac.c b/drivers/net/ethernet/meta/fbnic/fbnic_mac.c index be834983e981..8e6b589c25b8 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_mac.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_mac.c @@ -418,6 +418,18 @@ static void __fbnic_mac_stat_rd64(struct fbnic_dev *fbd, bool reset, u32 reg, stat->reported = true; } +static void fbnic_mac_stat_rd32(struct fbnic_dev *fbd, bool reset, u32 reg, + struct fbnic_stat_counter *stat) +{ + u32 new_reg_value; + + new_reg_value = rd32(fbd, reg); + if (!reset) + stat->value += new_reg_value - stat->u.old_reg_value_32; + stat->u.old_reg_value_32 = new_reg_value; + stat->reported = true; +} + #define fbnic_mac_stat_rd64(fbd, reset, __stat, __CSR) \ __fbnic_mac_stat_rd64(fbd, reset, FBNIC_##__CSR##_L, &(__stat)) @@ -812,6 +824,9 @@ fbnic_mac_get_pause_stats(struct fbnic_dev *fbd, bool reset, MAC_STAT_TX_XOFF_STB); fbnic_mac_stat_rd64(fbd, reset, pause_stats->rx_pause_frames, MAC_STAT_RX_XOFF_STB); + fbnic_mac_stat_rd32(fbd, reset, + FBNIC_RXB_INTR_PS_COUNT(FBNIC_RXB_INTF_NET), + &pause_stats->tx_pause_storm_events); } static void -- 2.47.3