From: Jason Gunthorpe <jgg@nvidia.com>
To: Junxian Huang <huangjunxian6@hisilicon.com>
Cc: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org,
Selvin Xavier <selvin.xavier@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
patches@lists.linux.dev
Subject: Re: [PATCH 01/10] RDMA: Add ib_copy_validate_udata_in()
Date: Mon, 9 Feb 2026 10:06:41 -0400 [thread overview]
Message-ID: <20260209140641.GC3076640@nvidia.com> (raw)
In-Reply-To: <5d569a30-832d-fe8d-1227-e409176b75ef@hisilicon.com>
On Mon, Feb 09, 2026 at 02:11:32PM +0800, Junxian Huang wrote:
> > +static inline int _ib_copy_validate_udata_in(struct ib_udata *udata, void *req,
> > + size_t kernel_size,
> > + size_t minimum_size)
> > +{
> > + int err;
> > +
> > + if (udata->inlen < minimum_size)
> > + return -EINVAL;
> > + err = copy_struct_from_user(req, kernel_size, udata->inbuf,
> > + udata->inlen);
> > + if (err) {
> > + if (err == E2BIG)
>
> The E2BIG should be negative.
Oops, thanks!!
Jason
next prev parent reply other threads:[~2026-02-09 14:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 1:45 [PATCH 00/10] Provide udata helpers and use them in bnxt_re Jason Gunthorpe
2026-02-06 1:45 ` [PATCH 01/10] RDMA: Add ib_copy_validate_udata_in() Jason Gunthorpe
2026-02-09 6:11 ` Junxian Huang
2026-02-09 14:06 ` Jason Gunthorpe [this message]
2026-02-06 1:45 ` [PATCH 02/10] RDMA: Add ib_copy_validate_udata_in_cm() Jason Gunthorpe
2026-02-06 1:45 ` [PATCH 03/10] RDMA: Add ib_respond_udata() Jason Gunthorpe
2026-02-13 10:10 ` Leon Romanovsky
2026-02-13 12:43 ` Jason Gunthorpe
2026-02-13 15:37 ` Leon Romanovsky
2026-02-13 15:48 ` Jason Gunthorpe
2026-02-16 23:14 ` Jason Gunthorpe
2026-02-17 7:48 ` Leon Romanovsky
2026-02-06 1:45 ` [PATCH 04/10] RDMA: Add ib_is_udata_in_empty() Jason Gunthorpe
2026-02-13 10:22 ` Leon Romanovsky
2026-02-13 12:56 ` Jason Gunthorpe
2026-02-06 1:45 ` [PATCH 05/10] RDMA: Provide documentation about the uABI compatibility rules Jason Gunthorpe
2026-02-13 10:23 ` Leon Romanovsky
2026-02-13 12:56 ` Jason Gunthorpe
2026-02-13 15:57 ` Leon Romanovsky
2026-02-18 0:01 ` Jason Gunthorpe
2026-02-06 1:45 ` [PATCH 06/10] RDMA/bnxt_re: Add compatibility checks to the uapi path Jason Gunthorpe
2026-02-08 19:29 ` Zhu Yanjun
2026-02-06 1:45 ` [PATCH 07/10] RDMA/bnxt_re: Add compatibility checks to the uapi path for no data Jason Gunthorpe
2026-02-13 10:34 ` Leon Romanovsky
2026-02-06 1:45 ` [PATCH 08/10] RDMA/bnxt_re: Add missing comp_mask validation Jason Gunthorpe
2026-02-06 1:45 ` [PATCH 09/10] RDMA/bnxt_re: Use ib_respond_udata() Jason Gunthorpe
2026-02-13 10:40 ` Leon Romanovsky
2026-02-13 12:42 ` Jason Gunthorpe
2026-02-13 15:39 ` Leon Romanovsky
2026-02-06 1:45 ` [PATCH 10/10] RDMA/bnxt_re: Add BNXT_RE_UCNTX_CMASK_UAPI_COMPAT_SUPPORTED Jason Gunthorpe
2026-02-06 12:20 ` [PATCH 00/10] Provide udata helpers and use them in bnxt_re Sriharsha Basavapatna
2026-02-06 19:11 ` Jason Gunthorpe
2026-02-09 12:28 ` Sriharsha Basavapatna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260209140641.GC3076640@nvidia.com \
--to=jgg@nvidia.com \
--cc=huangjunxian6@hisilicon.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=selvin.xavier@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox