From: Leon Romanovsky <leon@kernel.org>
To: Yonatan Nachum <ynachum@amazon.com>
Cc: jgg@nvidia.com, linux-rdma@vger.kernel.org, mrgolin@amazon.com,
sleybo@amazon.com, matua@amazon.com, gal.pressman@linux.dev,
Firas Jahjah <firasj@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Expose new extended max inline buff size
Date: Fri, 13 Feb 2026 13:35:10 +0200 [thread overview]
Message-ID: <20260213113510.GQ12887@unreal> (raw)
In-Reply-To: <20260211113346.9996-1-ynachum@amazon.com>
On Wed, Feb 11, 2026 at 11:33:46AM +0000, Yonatan Nachum wrote:
> Add new extended max inline query and report the new value to userspace.
>
> Reviewed-by: Firas Jahjah <firasj@amazon.com>
> Reviewed-by: Michael Margolin <mrgolin@amazon.com>
> Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
> ---
> .../infiniband/hw/efa/efa_admin_cmds_defs.h | 22 ++++++--
> drivers/infiniband/hw/efa/efa_com_cmd.c | 55 ++++++++++++-------
> drivers/infiniband/hw/efa/efa_com_cmd.h | 3 +-
> drivers/infiniband/hw/efa/efa_verbs.c | 3 +-
> include/uapi/rdma/efa-abi.h | 5 +-
> 5 files changed, 59 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> index 57178dad5eb7..93e5ffe900e9 100644
> --- a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> +++ b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
> /*
> - * Copyright 2018-2025 Amazon.com, Inc. or its affiliates. All rights reserved.
> + * Copyright 2018-2026 Amazon.com, Inc. or its affiliates. All rights reserved.
> */
>
> #ifndef _EFA_ADMIN_CMDS_H_
> @@ -38,10 +38,11 @@ enum efa_admin_aq_feature_id {
> EFA_ADMIN_DEVICE_ATTR = 1,
> EFA_ADMIN_AENQ_CONFIG = 2,
> EFA_ADMIN_NETWORK_ATTR = 3,
> - EFA_ADMIN_QUEUE_ATTR = 4,
> + EFA_ADMIN_QUEUE_ATTR_1 = 4,
> EFA_ADMIN_HW_HINTS = 5,
> EFA_ADMIN_HOST_INFO = 6,
> EFA_ADMIN_EVENT_QUEUE_ATTR = 7,
> + EFA_ADMIN_QUEUE_ATTR_2 = 8,
> };
<...>
> - result->max_qp = resp.u.queue_attr.max_qp;
> - result->max_sq_depth = resp.u.queue_attr.max_sq_depth;
> - result->max_rq_depth = resp.u.queue_attr.max_rq_depth;
> - result->max_cq = resp.u.queue_attr.max_cq;
> - result->max_cq_depth = resp.u.queue_attr.max_cq_depth;
> - result->inline_buf_size = resp.u.queue_attr.inline_buf_size;
> - result->max_sq_sge = resp.u.queue_attr.max_wr_send_sges;
> - result->max_rq_sge = resp.u.queue_attr.max_wr_recv_sges;
> - result->max_mr = resp.u.queue_attr.max_mr;
> - result->max_mr_pages = resp.u.queue_attr.max_mr_pages;
> - result->max_pd = resp.u.queue_attr.max_pd;
> - result->max_ah = resp.u.queue_attr.max_ah;
> - result->max_llq_size = resp.u.queue_attr.max_llq_size;
> - result->sub_cqs_per_cq = resp.u.queue_attr.sub_cqs_per_cq;
> - result->max_wr_rdma_sge = resp.u.queue_attr.max_wr_rdma_sges;
> - result->max_tx_batch = resp.u.queue_attr.max_tx_batch;
> - result->min_sq_depth = resp.u.queue_attr.min_sq_depth;
> + result->max_qp = resp.u.queue_attr_1.max_qp;
> + result->max_sq_depth = resp.u.queue_attr_1.max_sq_depth;
> + result->max_rq_depth = resp.u.queue_attr_1.max_rq_depth;
> + result->max_cq = resp.u.queue_attr_1.max_cq;
> + result->max_cq_depth = resp.u.queue_attr_1.max_cq_depth;
> + result->inline_buf_size = resp.u.queue_attr_1.inline_buf_size;
> + result->max_sq_sge = resp.u.queue_attr_1.max_wr_send_sges;
> + result->max_rq_sge = resp.u.queue_attr_1.max_wr_recv_sges;
> + result->max_mr = resp.u.queue_attr_1.max_mr;
> + result->max_mr_pages = resp.u.queue_attr_1.max_mr_pages;
> + result->max_pd = resp.u.queue_attr_1.max_pd;
> + result->max_ah = resp.u.queue_attr_1.max_ah;
> + result->max_llq_size = resp.u.queue_attr_1.max_llq_size;
> + result->sub_cqs_per_cq = resp.u.queue_attr_1.sub_cqs_per_cq;
> + result->max_wr_rdma_sge = resp.u.queue_attr_1.max_wr_rdma_sges;
> + result->max_tx_batch = resp.u.queue_attr_1.max_tx_batch;
> + result->min_sq_depth = resp.u.queue_attr_1.min_sq_depth;
Please split this patch to two: first is rename and second one is
addition.
Thanks
prev parent reply other threads:[~2026-02-13 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 11:33 [PATCH for-next] RDMA/efa: Expose new extended max inline buff size Yonatan Nachum
2026-02-12 6:32 ` Gal Pressman
2026-02-13 11:35 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260213113510.GQ12887@unreal \
--to=leon@kernel.org \
--cc=firasj@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox