Re: [PATCH for-next 2/3] RDMA/hns: Add write support to debugfs

[Leon Romanovsky <leon@kernel.org>]

On Fri, Feb 13, 2026 at 03:52:50PM +0800, Junxian Huang wrote:
> 
> 
> On 2026/2/13 0:55, Leon Romanovsky wrote:
> > On Fri, Feb 06, 2026 at 06:31:09PM +0800, Junxian Huang wrote:
> >> Add write support to debugfs.
> >>
> >> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
> >> ---
> >>  drivers/infiniband/hw/hns/hns_roce_debugfs.c | 38 +++++++++++++++++---
> >>  drivers/infiniband/hw/hns/hns_roce_debugfs.h |  1 +
> >>  2 files changed, 35 insertions(+), 4 deletions(-)
> > 
> > <...>
> > 
> >>  static const struct file_operations hns_debugfs_seqfile_fops = {
> >>  	.owner = THIS_MODULE,
> >>  	.open = hns_debugfs_seqfile_open,
> >>  	.release = single_release,
> >>  	.read = seq_read,
> >> +	.write = hns_debugfs_seqfile_write,
> >>  	.llseek = seq_lseek
> >>  };
> >>  
> > 
> > <...>
> > 
> >> -	debugfs_create_file(name, 0400, parent, seq, &hns_debugfs_seqfile_fops);
> >> +	debugfs_create_file(name, ops->write ? 0600 : 0400, parent,
> >> +			    seq, &hns_debugfs_seqfile_fops);
> > 
> > What is this "ops->write ?" check? You added write callback in this
> > exactly patch. It is always true.
> > 
> 
> This ops is the function argument "const struct hns_debugfs_rw_ops *ops", not
> the file_operations hns_debugfs_seqfile_fops. This ops->write can be NULL when
> the file is read-only, such as the change in create_sw_stat_debugfs() in this
> patch.

Excellent, inline your init_debugfs_seqfile().

Thanks

> 
> Junxian
> 
> > Thanks
> >