Re: [PATCH for-next 3/3] RDMA/hns: Support congestion control algorithm parameter configuration

[Leon Romanovsky <leon@kernel.org>]

On Fri, Feb 13, 2026 at 04:36:44PM +0800, Junxian Huang wrote:
> 
> 
> On 2026/2/13 0:57, Leon Romanovsky wrote:
> > On Fri, Feb 06, 2026 at 06:31:10PM +0800, Junxian Huang wrote:
> >> From: Chengchang Tang <tangchengchang@huawei.com>
> >>
> >> hns RoCE supports 4 congestion control algorithms. Each algorihm
> >> involves multiple parameters. Support configuring these parameters
> >> by debugfs.
> >>
> >> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> >> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
> >> ---
> >>  drivers/infiniband/hw/hns/hns_roce_debugfs.c | 278 +++++++++++++++++++
> >>  drivers/infiniband/hw/hns/hns_roce_debugfs.h |  25 ++
> >>  drivers/infiniband/hw/hns/hns_roce_device.h  |  25 ++
> >>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c   |  66 +++++
> >>  drivers/infiniband/hw/hns/hns_roce_hw_v2.h   | 140 ++++++++++
> >>  5 files changed, 534 insertions(+)
> > 
> > Please remove all these complexity, delayed work, 
> 
> Sure. Then we'll update HW immediately each time the user write a new value
> to the param file.
> 
> > multiple configuration options in one file, provide one directory with multiple files> Each file is a key, which can accept multiple values and not like it is implemented now.
> 
> If I understand your comment correctly, our current implementation already
> follows the structure you described. We don't have multiple configuration
> options in one file. We provide one directory with multiple files for each
> algorithm. Each file corresponds to one param.

I probably misread your patch, so let's simplify it and it will be more
clear.

Thanks