From: Leon Romanovsky <leon@kernel.org>
To: Gal Pressman <gal.pressman@linux.dev>
Cc: Michael Margolin <mrgolin@amazon.com>,
Jason Gunthorpe <jgg@nvidia.com>, Tom Sela <tomsela@amazon.com>,
linux-rdma@vger.kernel.org, sleybo@amazon.com, matua@amazon.com,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Add AH usage counter with sysfs exposure
Date: Sun, 15 Feb 2026 19:57:07 +0200 [thread overview]
Message-ID: <20260215175707.GC12989@unreal> (raw)
In-Reply-To: <42c8552c-eb41-43f5-bea5-fdd46edba65a@linux.dev>
On Sun, Feb 15, 2026 at 07:23:41PM +0200, Gal Pressman wrote:
> On 15/02/2026 19:15, Leon Romanovsky wrote:
> >> Stats also doesn't seem as the right place
> >> for this.
>
> Because?
>
> >
> > How can the kernel and this new counter report a different number of AH
> > objects?
> >
> >>
> >> In a followup series we will suggest netlink counters extension to
> >> support driver specific resources.
> >
> > bpftrace is generally the right tool, unless you can detail why it does not
> > fit your specific debugging scenario.
>
> I don't understand, how do you use bpftrace for this use case?
>
> Once you get to debug a system in a certain state, bpftrace won't help
> you see events that happened in the past. You won't be able to know how
> many AH were created.
Their proposed counter can be implemented by counting calls to
efa_com_create_ah minus calls to efa_com_destroy_ah.
You have two ways to get it:
1. run bfptrace with your reproducer
2. check FW to get their internal counter
Thanks
>
next prev parent reply other threads:[~2026-02-15 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 13:10 [PATCH for-next] RDMA/efa: Add AH usage counter with sysfs exposure Tom Sela
2026-02-11 13:13 ` Jason Gunthorpe
2026-02-12 6:52 ` Gal Pressman
2026-02-12 16:36 ` Leon Romanovsky
2026-02-15 13:41 ` Michael Margolin
2026-02-15 17:15 ` Leon Romanovsky
2026-02-15 17:23 ` Gal Pressman
2026-02-15 17:57 ` Leon Romanovsky [this message]
2026-02-16 11:08 ` Michael Margolin
2026-02-16 11:22 ` Leon Romanovsky
2026-02-17 14:54 ` Michael Margolin
2026-02-18 0:14 ` Jason Gunthorpe
2026-02-18 9:15 ` Leon Romanovsky
2026-02-18 17:27 ` Michael Margolin
2026-02-16 8:48 ` Michael Margolin
2026-02-16 9:41 ` Leon Romanovsky
2026-02-11 18:48 ` yanjun.zhu
2026-02-12 6:52 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260215175707.GC12989@unreal \
--to=leon@kernel.org \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=tomsela@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox