From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAA742E54CC for ; Mon, 16 Feb 2026 19:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771270812; cv=none; b=Wj/4y4HvjJIlCjIYYoNKfh+fOUUV6puQQcPREIh7ZYvp+9AN9NfTlrWHbL74do8sOYJvkmO+GZcgSNNn3Ug7+Lx949eyGLWLkV3MKRlWEfwW+c3v4AFqGIo0cNK7puqpx8D0IV9YjWH9PrAOmrpIIWk7Z6bNjaDAhId/8yNcDao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771270812; c=relaxed/simple; bh=oNx02DxJngR7P3lr+ifhUuMYiqOZkwb0bIBGHfMYRSk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IqutprOanAnSeUNyjmkWT8GQqBjNKsrxn8HUxlE3wnIdrQ+z0pnFMmTe7zlrfyKl/XTm+Jh5Hr5D6eJn8r+marFTMntm+PayQ0Np4YILEiYqeC1NiDnRX2mHxucnOlogb9kYxki1wkqTyNkCSJ2ZqGI0bNmQX1Vahj9TG0qd8L4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cbz9jROL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cbz9jROL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0BF3C116C6; Mon, 16 Feb 2026 19:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771270812; bh=oNx02DxJngR7P3lr+ifhUuMYiqOZkwb0bIBGHfMYRSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cbz9jROLBwjsGuIJgWoxRep2cnmu06VFNAHlxxvbR1lB9P64pA5pAF4KtdiQ6u537 kL1Upgl5AHvPdYOUOUX0oEDy5RxEv4wSWYVB3Lchm2kgXl5jXV3mgsmH/39P4E9L6u mZOYlSoF0n8fMaWDWMa6GQ3hLVh8WYs+0IfUA9z0EJqwM5u1Pz+UFFQKftWUdNFKZH VasOEnz/2RHazLKfOq1WfQgVOKL6roHXC2yfIp6ZojsVABqthuHBKAFXvOGu/P3I9i XegdW/BMj/iFsC4wqSgb6mrLMBdHwlX1gZpkQefb4YbLNVx8zbhErSO3m70e3+B+Nk t8+69pY9ovWdA== Date: Mon, 16 Feb 2026 21:40:08 +0200 From: Leon Romanovsky To: Sriharsha Basavapatna Cc: Jason Gunthorpe , linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, selvin.xavier@broadcom.com, kalesh-anakkur.purayil@broadcom.com Subject: Re: [PATCH rdma-next v12 5/6] RDMA/bnxt_re: Support dmabuf for CQ rings Message-ID: <20260216194008.GG12989@unreal> References: <20260211124927.57617-1-sriharsha.basavapatna@broadcom.com> <20260211124927.57617-6-sriharsha.basavapatna@broadcom.com> <20260213111256.GO12887@unreal> <20260213145425.GN750753@ziepe.ca> <20260213162211.GX12887@unreal> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Feb 16, 2026 at 08:30:35PM +0530, Sriharsha Basavapatna wrote: > On Fri, Feb 13, 2026 at 9:52 PM Leon Romanovsky wrote: > > > > On Fri, Feb 13, 2026 at 10:54:25AM -0400, Jason Gunthorpe wrote: > > > On Fri, Feb 13, 2026 at 01:12:56PM +0200, Leon Romanovsky wrote: > > > > > +int bnxt_re_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr, > > > > > + struct uverbs_attr_bundle *attrs) > > > > > +{ > > > > > + return bnxt_re_create_cq_umem(ibcq, attr, NULL, attrs); > > > > > +} > > > > > > > > Please don't mix create_cq and create_cq_umem. > > > > https://lore.kernel.org/linux-rdma/20260213-refactor-umem-v1-15-f3be85847922@nvidia.com/T/#u > > > > > > Either we drop this one patch and put those 50 ahead of it, or we just > > > take this one and rebase the above.. The above has the advantage that > > > it enables all drivers to support cq dmabuf in one giant shot. > > > > > > However, frankly I'm getting tired of looking at this bnxt_re stuff so > > > I'd like to just see it done. > > > > In addition, push them to create 2 separate functions. > > One is .create_cq_umem() for uverbs flow and another .create_cq() > > variant for kernel flow. > > > > bnxt_re_create_cq() > > { > > if (udata) > > return bnxt_re_create_cq_umem() > > > > .... > > } > > > > It will allow me to rebase my series more easily. > > > > Thanks > The above change can be done as a separate patch once the current > bnxt_re patch series gets merged. > I can push that before your patchset > is ready to be merged. If you still want this change in the current > series itself, I can do that too. Please confirm. No concerns were raised about the first eight patches, so they are ready to merge. This series, however, still requires further work. Thanks > > Thanks, > -Harsha > > > > > > > > Jason