public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Jacob Moroni <jmoroni@google.com>,
	tatyana.e.nikolova@intel.com, krzysztof.czurylo@intel.com,
	linux-rdma@vger.kernel.org
Subject: Re: [RFC] RDMA/irdma: Add support for revocable dmabuf import
Date: Wed, 18 Feb 2026 11:05:09 +0200	[thread overview]
Message-ID: <20260218090509.GD10368@unreal> (raw)
In-Reply-To: <20260217232158.GQ750753@ziepe.ca>

On Tue, Feb 17, 2026 at 07:21:58PM -0400, Jason Gunthorpe wrote:
> On Tue, Feb 17, 2026 at 06:08:54PM -0500, Jacob Moroni wrote:
> > Hi,
> > 
> > Thanks for taking a look.

<...>

> > Should I create a new kernel device method for this? If so, then I wonder if
> > it makes sense to expose it as a generic "invalidate_mr" method and let
> > the drivers choose now to actually implement it (many can probably just
> > forward the call to their internal rereg_mr logic).
> 
> I have on and off thought about doing something like that with rereg
> mr as it would be more general, but I think for now just extending the
> ib_umem_dmabuf_get_pinned() is reasonable, and avoids the races.

I'm in the camp that, sooner or later, we will need a generic solution in
ib_core to handle this. More and more drivers now support dmabuf in RDMA,
and most of them lack ODP, so they will all need to implement
invalidate_mr at some point.

That said, starting with the simplest reasonable approach and refactoring
later sounds fine.

Thanks

  reply	other threads:[~2026-02-18  9:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17 18:21 [RFC] RDMA/irdma: Add support for revocable dmabuf import Jacob Moroni
2026-02-17 18:45 ` Jason Gunthorpe
2026-02-17 23:08   ` Jacob Moroni
2026-02-17 23:21     ` Jason Gunthorpe
2026-02-18  9:05       ` Leon Romanovsky [this message]
2026-02-18 15:24         ` Jacob Moroni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218090509.GD10368@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=jmoroni@google.com \
    --cc=krzysztof.czurylo@intel.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=tatyana.e.nikolova@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox