From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
linux-rdma@vger.kernel.org,
Selvin Xavier <selvin.xavier@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
patches@lists.linux.dev
Subject: Re: [PATCH v2 00/13] Provide udata helpers and use them in bnxt_re
Date: Mon, 2 Mar 2026 15:33:43 -0400 [thread overview]
Message-ID: <20260302193343.GX5933@nvidia.com> (raw)
In-Reply-To: <20260302192413.GS12611@unreal>
On Mon, Mar 02, 2026 at 09:24:13PM +0200, Leon Romanovsky wrote:
> On Thu, Feb 26, 2026 at 09:11:03PM -0400, Jason Gunthorpe wrote:
> > Add new helpers that entirely execute the expected common patterns for
> > driver data uAPI forward and backwards compatibility so that drivers don't
> > have to open code these.
>
> <...>
>
> > Since bnxt_re has never implemented these rules correctly and now does,
> > provide a UCTX flag to tell userspace about it. If
> > BNXT_RE_UCNTX_CMASK_UAPI_COMPAT_SUPPORTED is not set then userspace must
> > not use any request or response fields beyond the current kernel uAPI.
> >
> > Using any new fields is only possible on kernels with the flag.
>
> Does a similar flag exist in any other driver? If so, we should consider
> making it global to ib_uverbs. If not, keeping it bnxt_re‑specific is
> sufficient.
I've been thinking about this too..
I think I'm pretty close in other drivers to being able to make the
same statement.
Maybe it should be a global flag in the uctx uAPI
Jason
prev parent reply other threads:[~2026-03-02 19:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 1:11 [PATCH v2 00/13] Provide udata helpers and use them in bnxt_re Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 01/13] RDMA: Use copy_struct_from_user() instead of open coding Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 02/13] RDMA/core: Add rdma_udata_to_dev() Jason Gunthorpe
2026-03-02 19:30 ` Leon Romanovsky
2026-03-02 19:36 ` Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 03/13] RDMA: Add ib_copy_validate_udata_in() Jason Gunthorpe
2026-02-27 7:50 ` kernel test robot
2026-02-28 10:24 ` kernel test robot
2026-02-27 1:11 ` [PATCH v2 04/13] RDMA: Add ib_copy_validate_udata_in_cm() Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 05/13] RDMA: Add ib_respond_udata() Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 06/13] RDMA: Add ib_is_udata_in_empty() Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 07/13] RDMA: Provide documentation about the uABI compatibility rules Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 08/13] RDMA/bnxt_re: Add compatibility checks to the uapi path Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 09/13] RDMA/bnxt_re: Add compatibility checks to the uapi path for no data Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 10/13] RDMA/bnxt_re: Add missing comp_mask validation Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 11/13] RDMA/bnxt_re: Use ib_respond_udata() Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 12/13] RDMA/bnxt_re: Use ib_respond_empty_udata() Jason Gunthorpe
2026-02-27 1:11 ` [PATCH v2 13/13] RDMA/bnxt_re: Add BNXT_RE_UCNTX_CMASK_UAPI_COMPAT_SUPPORTED Jason Gunthorpe
2026-03-02 19:24 ` [PATCH v2 00/13] Provide udata helpers and use them in bnxt_re Leon Romanovsky
2026-03-02 19:33 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302193343.GX5933@nvidia.com \
--to=jgg@nvidia.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=selvin.xavier@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox