Re: [PATCH v3 13/13] RDMA: Add IB_UVERBS_CORE_SUPPORT_ROBUST_UDATA

[Jason Gunthorpe <jgg@nvidia.com>]

On Wed, Mar 04, 2026 at 12:05:11PM +0530, Sriharsha Basavapatna wrote:
> On Wed, Mar 4, 2026 at 1:20 AM Jason Gunthorpe <jgg@nvidia.com> wrote:
> >
> > This flag can be set by drivers once they have finished auditing and
> > implementing the full udata support on every udata operation.
> >
> > My intention going forward is that driver authors proposing new udata uAPI
> > for their drivers must first do the work and set this flag.
> >
> > If this flag is not set the userspace should not try to use udata based
> > uAPI newer than this commit, though on a case by case basis it may be OK
> > based on what checks historical kernels performed on the specific call.
> >
> > Since bnxt_re is audited now, it is the first driver to set the flag.
> >
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > ---
> >  drivers/infiniband/core/device.c                  | 1 +
> >  drivers/infiniband/core/uverbs_std_types_device.c | 8 ++++++++
> >  drivers/infiniband/hw/bnxt_re/main.c              | 1 +
> >  include/rdma/ib_verbs.h                           | 6 ++++++
> >  include/uapi/rdma/ib_user_ioctl_verbs.h           | 1 +
> >  5 files changed, 17 insertions(+)
> >
> > diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> > index 558b73940d6681..5b4fb47cbaeee6 100644
> > --- a/drivers/infiniband/core/device.c
> > +++ b/drivers/infiniband/core/device.c
> > @@ -2706,6 +2706,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)
> >
> >         dev_ops->uverbs_no_driver_id_binding |=
> >                 ops->uverbs_no_driver_id_binding;
> > +       dev_ops->uverbs_robust_udata |= dev_ops->uverbs_robust_udata;
> this should be: dev_ops->uverbs_robust_udata |= ops->uverbs_robust_udata;

Oops, are you OK otherwise?

Thanks,
Jason