Re: [PATCH v5 4/4] RDMA/rxe: Add testcase for net namespace rxe

[Leon Romanovsky <leon@kernel.org>]

On Tue, Mar 10, 2026 at 02:01:03PM -0700, Yanjun.Zhu wrote:
> 
> On 3/10/26 11:53 AM, Leon Romanovsky wrote:
> > On Tue, Mar 10, 2026 at 03:05:18AM +0100, Zhu Yanjun wrote:
> > > Add 4 testcases for rxe with net namespace.
> > > 
> > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> > > ---
> > >   MAINTAINERS                                   |  1 +
> > >   tools/testing/selftests/Makefile              |  1 +
> > >   tools/testing/selftests/rdma/Makefile         |  7 ++
> > >   tools/testing/selftests/rdma/config           |  3 +
> > >   tools/testing/selftests/rdma/rxe_ipv6.sh      | 63 ++++++++++++++
> > >   .../selftests/rdma/rxe_rping_between_netns.sh | 85 +++++++++++++++++++
> > >   .../selftests/rdma/rxe_socket_with_netns.sh   | 76 +++++++++++++++++
> > >   .../rdma/rxe_test_NETDEV_UNREGISTER.sh        | 63 ++++++++++++++
> > >   8 files changed, 299 insertions(+)
> > >   create mode 100644 tools/testing/selftests/rdma/Makefile
> > >   create mode 100644 tools/testing/selftests/rdma/config
> > >   create mode 100755 tools/testing/selftests/rdma/rxe_ipv6.sh
> > >   create mode 100755 tools/testing/selftests/rdma/rxe_rping_between_netns.sh
> > >   create mode 100755 tools/testing/selftests/rdma/rxe_socket_with_netns.sh
> > >   create mode 100755 tools/testing/selftests/rdma/rxe_test_NETDEV_UNREGISTER.sh
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 77fdfcb55f06..bd33edf79150 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -24492,6 +24492,7 @@ L:	linux-rdma@vger.kernel.org
> > >   S:	Supported
> > >   F:	drivers/infiniband/sw/rxe/
> > >   F:	include/uapi/rdma/rdma_user_rxe.h
> > > +F:	tools/testing/selftests/rdma/
> > This is wrong place in MAINTAINERS file.
> > You need to add that line to "INFINIBAND SUBSYSTEM" and under RXE to add
> > tools/testing/selftests/rdma/rxe* entry.
> 
> Hi, Leon
> 
> "
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> 
> index 77fdfcb55f06..3c6bc0e05fc0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24492,6 +24492,7 @@ L:      linux-rdma@vger.kernel.org
>  S:     Supported
>  F:     drivers/infiniband/sw/rxe/
>  F:     include/uapi/rdma/rdma_user_rxe.h
> +F:     tools/testing/selftests/rdma/rxe*
> 
> "
> 
> Is it OK?

It is not sufficient. We also need to be CCed on changes to
tools/testing/selftests/rdma/Makefile. For that reason, you should place
tools/testing/selftests/rdma/ under the "INFINIBAND SUBSYSTEM" as well.

Thanks

> 
> Zhu Yanjun
> 
> > 
> > Thanks
>