Re: [PATCH for-next v2] RDMA/hfi2: Consolidate ABI files and setup uverbs access

[Leon Romanovsky <leon@kernel.org>]

On Wed, Mar 18, 2026 at 05:35:58PM +0200, Leon Romanovsky wrote:
> On Wed, Mar 18, 2026 at 11:08:16AM -0400, Dennis Dalessandro wrote:
> > hfi1 driver is being replaced eventually with an hfi2 driver. Until that
> > happens rather than have all the duplicated code in header files, make hfi1
> > use hfi2 variants where it can. When compatibility breaks we'll keep a
> > separate hfi1 version.
> > 
> > This is the case for the <dev>_status struture. The hfi1 varaint is single
> > port and uses a freezemsg char array while the new hfi2 chip provides
> > multiple ports and thus needs and array of ports.
> > 
> > Likewise the tid info struct is expanded for hfi2 so we include both an
> > hfi1 and hfi2 vaiant.
> > 
> > There is a naming conflict with the trace_hfi1_ctxt_info() call. It has been
> > renamed to remove the 1 from the function name to keep the code readable
> > but allow it to compile due to the #define in hfi1_ioctl.h.
> > 
> > The big departure from hfi1 is that we are no longer supporting access from
> > users through a private character device. Instead we define two custom
> > verbs ojects. dv0/1, which proivdes methods for what in hfi1 are individual
> > IOCTLs. We have added an additional method to get stats related to page
> > pinning done by the driver.
> > 
> > The hfi1_user.h is no longer needed and is removed from the uapi directory.
> > There is a private compat header in hfi1 that will be deleted when hfi1 is.
> > This removes driver specific content from generic RDMA UAPI headers.
> > 
> > Co-developed-by: Dean Luick <dean.luick@cornelisnetworks.com>
> > Signed-off-by: Dean Luick <dean.luick@cornelisnetworks.com>
> > Co-developed-by: Bendan Cunningham <brendan.cunningham@cornelisnetworks.com>
> > Signed-off-by: Breandan Cunningham <brendan.cunningham@cornelisnetworks.com>
> > Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> > 
> > ---

<...>

> > +#endif /* _LINIUX_HFI2_USER_H */
> > diff --git a/include/uapi/rdma/ib_user_ioctl_verbs.h b/include/uapi/rdma/ib_user_ioctl_verbs.h
> > index 89e6a3f13191..c7573131c862 100644
> > --- a/include/uapi/rdma/ib_user_ioctl_verbs.h
> > +++ b/include/uapi/rdma/ib_user_ioctl_verbs.h
> > @@ -256,6 +256,7 @@ enum rdma_driver_id {
> >  	RDMA_DRIVER_ERDMA,
> >  	RDMA_DRIVER_MANA,
> >  	RDMA_DRIVER_IONIC,
> > +	RDMA_DRIVER_HFI2,
> 
> This hunk should be separated and submitted as part of hfi2 addition.

BTW, you can also try something similar to RDMA_DRIVER_IRDMA where Intel
used same ID for irdma and I40IW.

Thanks