public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
To: leon@kernel.org
Cc: dledford@redhat.com, haggaie@mellanox.com, jgg@ziepe.ca,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	prathameshdeshpande7@gmail.com
Subject: Re: [PATCH] IB/mlx5: Fix memory leak in GSI QP destroy error path
Date: Tue, 31 Mar 2026 19:04:02 +0100	[thread overview]
Message-ID: <20260331180531.16845-1-prathameshdeshpande7@gmail.com> (raw)
In-Reply-To: <20260331134508.GD814676@unreal>

On Tue, Mar 31, 2026 at 04:45:08PM +0300, Leon Romanovsky wrote:
> GSI QP are different from other "best-effort" failures. It MUST to fail.
> We are intentionally leaking resources here.

Hi Leon,

Thank you for the explanation.

I understand now that for GSI QPs, the hardware constraints make a
memory leak preferable to the risk of an inconsistency in this
failure path.

I'll keep this in mind for future mlx5 cleanup patches.

Thanks,
Prathamesh

      reply	other threads:[~2026-03-31 18:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31  0:48 [PATCH] IB/mlx5: Fix memory leak in GSI QP destroy error path Prathamesh Deshpande
2026-03-31 13:45 ` Leon Romanovsky
2026-03-31 18:04   ` Prathamesh Deshpande [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260331180531.16845-1-prathameshdeshpande7@gmail.com \
    --to=prathameshdeshpande7@gmail.com \
    --cc=dledford@redhat.com \
    --cc=haggaie@mellanox.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox