From: Edward Srouji <edwards@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>,
"Chiara Meiohas" <cmeiohas@nvidia.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Gal Pressman <galpress@amazon.com>,
Mark Bloch <markb@mellanox.com>,
Steve Wise <larrystevenwise@gmail.com>,
Mark Zhang <markzhang@nvidia.com>,
"Neta Ostrovsky" <netao@nvidia.com>,
Patrisious Haddad <phaddad@nvidia.com>,
"Doug Ledford" <dledford@redhat.com>,
Matan Barak <matanb@mellanox.com>, <majd@mellanox.com>,
Maor Gottlieb <maorg@mellanox.com>
Cc: <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Edward Srouji" <edwards@nvidia.com>,
Michael Guralnik <michaelgur@nvidia.com>,
"Maher Sanalla" <msanalla@nvidia.com>
Subject: [PATCH rdma-next v2 00/11] RDMA: Stability and race condition fixes
Date: Mon, 6 Apr 2026 12:11:11 +0300 [thread overview]
Message-ID: <20260406-security-bug-fixes-v2-0-ee8815fa81b7@nvidia.com> (raw)
This series addresses several stability issues in RDMA core and the
mlx5 driver, mainly around use-after-free conditions in resource
destruction paths and race windows in concurrent create/destroy flows.
Patches 1-6 fix a restrack race window affecting QP, CQ and SRQ
resources in destroy flows.
The core problem is that rdma_restrack_del() was being called at the
end of the destroy routines, leaving a window where the resource could
still be looked up via netlink after vendor-specific resources were
already freed. Three preparatory patches lay the groundwork followed by
three fixes.
Patches 7-8 fix xarray race conditions in the mlx5 SRQ and DCT destroy
paths where a concurrent create can reuse the same firmware object
number right after firmware releases it, causing the destroy path to
incorrectly erase the newly created entry.
The remaining patches are independent fixes.
Signed-off-by: Edward Srouji <edwards@nvidia.com>
---
Changes in v2:
- Added patch "RDMA/mlx5: Remove raw RSS QP restrack tracking" to
also suppress broken tracking for raw RSS QPs, which suffer from
the same silent failures as DCTs
- Link to v1: https://lore.kernel.org/r/20260325-security-bug-fixes-v1-0-c8332981ad26@nvidia.com
---
Edward Srouji (2):
RDMA/mlx5: Fix UAF in SRQ destroy due to race with create
RDMA/mlx5: Fix UAF in DCT destroy due to race with create
Maher Sanalla (1):
IB/core: Fix IPv6 netlink message size in ib_nl_ip_send_msg()
Michael Guralnik (2):
RDMA/core: Fix rereg_mr use-after-free race
RDMA/mlx5: Fix null-ptr-deref in Raw Packet QP creation
Patrisious Haddad (6):
RDMA/mlx5: Remove DCT restrack tracking
RDMA/mlx5: Remove raw RSS QP restrack tracking
RDMA/core: Preserve restrack resource ID on reinsertion
RDMA/core: Fix use after free in ib_query_qp()
RDMA/core: Fix potential use after free in ib_destroy_cq_user()
RDMA/core: Fix potential use after free in ib_destroy_srq_user()
drivers/infiniband/core/addr.c | 2 +-
drivers/infiniband/core/restrack.c | 20 ++++++++++++++++----
drivers/infiniband/core/uverbs_cmd.c | 9 +++++++--
drivers/infiniband/core/verbs.c | 21 ++++++++++++++++-----
drivers/infiniband/hw/mlx5/qp.c | 7 +++++++
drivers/infiniband/hw/mlx5/qpc.c | 9 ++++++++-
drivers/infiniband/hw/mlx5/restrack.c | 3 ---
drivers/infiniband/hw/mlx5/srq_cmd.c | 9 ++++++++-
8 files changed, 63 insertions(+), 17 deletions(-)
---
base-commit: 6edef31ef9004ed51624246a04f7f81112f485b0
change-id: 20260325-security-bug-fixes-6fdef22d9412
Best regards,
--
Edward Srouji <edwards@nvidia.com>
next reply other threads:[~2026-04-06 9:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 9:11 Edward Srouji [this message]
2026-04-06 9:11 ` [PATCH rdma-next v2 01/11] RDMA/mlx5: Remove DCT restrack tracking Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 02/11] RDMA/mlx5: Remove raw RSS QP " Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 03/11] RDMA/core: Preserve restrack resource ID on reinsertion Edward Srouji
2026-04-06 22:23 ` Jason Gunthorpe
2026-04-07 9:18 ` Patrisious Haddad
2026-04-07 14:29 ` Jason Gunthorpe
2026-04-06 9:11 ` [PATCH rdma-next v2 04/11] RDMA/core: Fix use after free in ib_query_qp() Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 05/11] RDMA/core: Fix potential use after free in ib_destroy_cq_user() Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 06/11] RDMA/core: Fix potential use after free in ib_destroy_srq_user() Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 07/11] RDMA/mlx5: Fix UAF in SRQ destroy due to race with create Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 08/11] RDMA/mlx5: Fix UAF in DCT " Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 09/11] IB/core: Fix IPv6 netlink message size in ib_nl_ip_send_msg() Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 10/11] RDMA/core: Fix rereg_mr use-after-free race Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 11/11] RDMA/mlx5: Fix null-ptr-deref in Raw Packet QP creation Edward Srouji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406-security-bug-fixes-v2-0-ee8815fa81b7@nvidia.com \
--to=edwards@nvidia.com \
--cc=cmeiohas@nvidia.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@ziepe.ca \
--cc=larrystevenwise@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=majd@mellanox.com \
--cc=maorg@mellanox.com \
--cc=markb@mellanox.com \
--cc=markzhang@nvidia.com \
--cc=matanb@mellanox.com \
--cc=michaelgur@nvidia.com \
--cc=msanalla@nvidia.com \
--cc=netao@nvidia.com \
--cc=phaddad@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox