From: Jason Gunthorpe <jgg@ziepe.ca>
To: Edward Srouji <edwards@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Chiara Meiohas <cmeiohas@nvidia.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Gal Pressman <galpress@amazon.com>,
Mark Bloch <markb@mellanox.com>,
Steve Wise <larrystevenwise@gmail.com>,
Mark Zhang <markzhang@nvidia.com>,
Neta Ostrovsky <netao@nvidia.com>,
Patrisious Haddad <phaddad@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
Matan Barak <matanb@mellanox.com>,
majd@mellanox.com, Maor Gottlieb <maorg@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next v2 03/11] RDMA/core: Preserve restrack resource ID on reinsertion
Date: Mon, 6 Apr 2026 19:23:56 -0300 [thread overview]
Message-ID: <20260406222356.GJ2551565@ziepe.ca> (raw)
In-Reply-To: <20260406-security-bug-fixes-v2-3-ee8815fa81b7@nvidia.com>
On Mon, Apr 06, 2026 at 12:11:14PM +0300, Edward Srouji wrote:
> From: Patrisious Haddad <phaddad@nvidia.com>
>
> rdma_restrack_add() currently always allocates a new ID via
> xa_alloc_cyclic(), regardless of whether res->id is already set.
> This change makes sure that the object’s ID remains the same across
> removal and reinsertion to restrack.
It would be better to somehow pre-delete it so it is still in the
xarray but somehow blocked and then allow un pre-deleting. del/add
pairs are not a good design.
Jason
next prev parent reply other threads:[~2026-04-06 22:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 9:11 [PATCH rdma-next v2 00/11] RDMA: Stability and race condition fixes Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 01/11] RDMA/mlx5: Remove DCT restrack tracking Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 02/11] RDMA/mlx5: Remove raw RSS QP " Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 03/11] RDMA/core: Preserve restrack resource ID on reinsertion Edward Srouji
2026-04-06 22:23 ` Jason Gunthorpe [this message]
2026-04-07 9:18 ` Patrisious Haddad
2026-04-07 14:29 ` Jason Gunthorpe
2026-04-06 9:11 ` [PATCH rdma-next v2 04/11] RDMA/core: Fix use after free in ib_query_qp() Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 05/11] RDMA/core: Fix potential use after free in ib_destroy_cq_user() Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 06/11] RDMA/core: Fix potential use after free in ib_destroy_srq_user() Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 07/11] RDMA/mlx5: Fix UAF in SRQ destroy due to race with create Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 08/11] RDMA/mlx5: Fix UAF in DCT " Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 09/11] IB/core: Fix IPv6 netlink message size in ib_nl_ip_send_msg() Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 10/11] RDMA/core: Fix rereg_mr use-after-free race Edward Srouji
2026-04-06 9:11 ` [PATCH rdma-next v2 11/11] RDMA/mlx5: Fix null-ptr-deref in Raw Packet QP creation Edward Srouji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406222356.GJ2551565@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=cmeiohas@nvidia.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=edwards@nvidia.com \
--cc=galpress@amazon.com \
--cc=larrystevenwise@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=majd@mellanox.com \
--cc=maorg@mellanox.com \
--cc=markb@mellanox.com \
--cc=markzhang@nvidia.com \
--cc=matanb@mellanox.com \
--cc=netao@nvidia.com \
--cc=phaddad@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox