From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3CF9349AEA for ; Wed, 8 Apr 2026 18:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775673905; cv=none; b=T5inK6ZlP7sj879TFjEtf9DOeIxEVd8WO0oKEqCumCetR02/3IgzUlCl341AEsIsfnR63l1yyO9dTAWIuea+oom/wCVUGW8HiBxQ9bK995iDii1LB4MuKYcq24v50dbyWZ/YYwk+8U0kNZ1FvHDgaejOfaHPbxvjik1/rigjczk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775673905; c=relaxed/simple; bh=4ourjhFNyqPpKvwJ8NGSQQW1AjLtpzj4KUeHaeRYcQA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MqGwbkV4NyovS8rG1yLIHHqZn7o7nfYGhXfEEvYDGO5cDaIsHtolTIkWRSh+jQAvXdaLA69DN4j1ITWJeM/pvevFmx9Sp5KUDV0RVZ1Ponn2QaC0A2lyscvmiL7ukCYQ5kluTu3Flvpb38BbteyGfly9az/58BPxG2yuBze0OSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com; spf=none smtp.mailfrom=readmodwrite.com; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b=rsHR1N/V; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b="rsHR1N/V" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so708965e9.2 for ; Wed, 08 Apr 2026 11:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1775673902; x=1776278702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L0S2R3Jh2NO33hqto219r9Y9rGESH0KYk2ZJTa8dPv8=; b=rsHR1N/VHqNNP8XX6Jrmq9EEVyPDajohdFH+bV0TxBEXiIuktL9kqHyb57w2rNIyPb +rDbJUG7C0YJDG1c+kYdcKbL+DqFeKRynu0XV9hDEaFcUSLh962lD+B8DZthZ++xXq1d z5HYOtzc6XK1uE7abDbbxrHkyqnILL1rN0tZu9xGZI5o8NKpQShkaE4FPsoHRORDA5HK E+um06b/PAhfjFyj0MMC69k33uiKUgc9bwjrP4ZG7WYE9hfhtYGwMw5aGUGbHN9WcQcW hLt6jbe7oTD2tat0Ox7IsCGKHN8tgBOxM9ZHv4KTkZnVBySmEb3jjet4uuwqQTGdM7Uo vH5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775673902; x=1776278702; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L0S2R3Jh2NO33hqto219r9Y9rGESH0KYk2ZJTa8dPv8=; b=TwJSrcXp1V2hz9TTyMa7trsau7sqZyIgFMPr9gB5xn0RBpyr3Gd8zvX+DcXp4xOq2V DAfe9hpubxse9H0jKSE/zGMcnTCiVimskOJ7HuQF+3gZgtpvSQoKMkKLkbLOxx6bmOZj CjkNEF8wCznQ+2efvAuhfdfec3tfs9c2jAAW2Vx+VTrE1a/7WzAIfm3eP948g30cTFPV 5loRueb8F8yHoXENL0p7WRKMe+pruCCtWvxfKerNUjtpurBNux9yTCUhntqITdhiFz1R zayflM8NypQvVk1QWH607Rv3uHjeh6ph/tOXeknepvkwxpnUwaYihbeZ8T5txW6UUXJl cwJg== X-Forwarded-Encrypted: i=1; AJvYcCU+ExzgXy2s9vd+HQ/tbSpCn9jFJX3/RdBNYEsj+YLj7D/LyOm9ifXyzHnFzjBOyphmiILpzI16mSsV@vger.kernel.org X-Gm-Message-State: AOJu0YyilPU4OtBMgrlamobPjUoZdf6eZhwzZNwZwUeVpXhns/BoE3R1 RMeqgTTFtk8yCbl7M0ty573tW538JONVbgnEolXlUsvrbkrMdgmucqL+1vrlocVg36A= X-Gm-Gg: AeBDieuXC/HoKBOxz6D/FAhuQv+aLPDdDdChlSHehs+hiR/adJZTXwKliwXn2sfe//v hEEdfHjwPJSp5DypIOS+/Ng4AToQNe6SvW6ZjsdxjuwLwvrZHHsBGkEj7b8Sj6OBZqnv6s0V2wl uKB781jNMN6VdqSUMxgKtwRn3mcHscpiarnpGy/Ihy9s9CJn4CRD8DGTa6hvbsfXorbiPtvnZVs EDpyvFCajNwo/K0/lSv/Ur9puNxpf/Ezlz0fAl0WmHLno1wM6NMx69UVZZFlUA5dARuQLm6k0ym Wus3pDZF68l2qQo1lErhL04q4HWgVzMm99/+JTqEWylRIRfUb5MsPs8+y8Jh/iQagicKakJ+wbi 4Gm4Tf4Yw4bnf9W3ldcAaoA2LgnIEvdgYEhj/BBzZLrR1GJoFJWiIMJtQumEUnvEWGnL2yXZeU/ n1eJ7HiudraXcR6oyvUXb4VEENgA== X-Received: by 2002:a05:600c:8b52:b0:486:f9d0:aac8 with SMTP id 5b1f17b1804b1-4889978140bmr335703905e9.18.1775673901890; Wed, 08 Apr 2026 11:45:01 -0700 (PDT) Received: from matt-Precision-5490.. ([2a09:bac6:37a8:ec8::179:1f4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488cd0f4d7bsm8293615e9.1.2026.04.08.11.45.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 11:45:01 -0700 (PDT) From: Matt Fleming To: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Matt Fleming Subject: [PATCH net] net/mlx5e: Fix use-after-free in mlx5e_tx_reporter_timeout_recover Date: Wed, 8 Apr 2026 19:44:58 +0100 Message-ID: <20260408184458.1274662-1-matt@readmodwrite.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Matt Fleming mlx5e_tx_reporter_timeout_recover() accesses sq->netdev after mlx5e_safe_reopen_channels() has torn down and freed the channel (and its embedded SQs). Replace the three sq->netdev references with priv->netdev which is safe because priv outlives channel teardown. The netdev_err() call already used priv->netdev for this reason; make the trylock/unlock and health_channel_eq_recover calls consistent. This fixes the following KASAN splat: BUG: KASAN: use-after-free in mlx5e_tx_reporter_timeout_recover+0x1dd/0x360 [mlx5_core] Read of size 8 at addr ffff889860ed0b28 by task kworker/u113:2/5277 Call Trace: mlx5e_tx_reporter_timeout_recover+0x1dd/0x360 [mlx5_core] devlink_health_reporter_recover+0xa2/0x150 devlink_health_report+0x254/0x7c0 mlx5e_reporter_tx_timeout+0x297/0x380 [mlx5_core] mlx5e_tx_timeout_work+0x109/0x170 [mlx5_core] process_one_work+0x677/0xf20 worker_thread+0x51f/0xd90 kthread+0x3a5/0x810 ret_from_fork+0x208/0x400 ret_from_fork_asm+0x1a/0x30 Fixes: 83ac0304a2d7 ("net/mlx5e: Fix deadlocks between devlink and netdev instance locks") Signed-off-by: Matt Fleming --- drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c index afdeb1b3d425..8409ae73768f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c @@ -160,13 +160,13 @@ static int mlx5e_tx_reporter_timeout_recover(void *ctx) * channels are being closed for other reason and this work is not * relevant anymore. */ - while (!netdev_trylock(sq->netdev)) { + while (!netdev_trylock(priv->netdev)) { if (!test_bit(MLX5E_STATE_CHANNELS_ACTIVE, &priv->state)) return 0; msleep(20); } - err = mlx5e_health_channel_eq_recover(sq->netdev, eq, sq->cq.ch_stats); + err = mlx5e_health_channel_eq_recover(priv->netdev, eq, sq->cq.ch_stats); if (!err) { to_ctx->status = 0; /* this sq recovered */ goto out; @@ -186,7 +186,7 @@ static int mlx5e_tx_reporter_timeout_recover(void *ctx) "mlx5e_safe_reopen_channels failed recovering from a tx_timeout, err(%d).\n", err); out: - netdev_unlock(sq->netdev); + netdev_unlock(priv->netdev); return err; } -- 2.43.0