Re: [PATCH for-next 1/4] RDMA/core: Add Completion Counters support

[Jason Gunthorpe <jgg@nvidia.com>]

On Thu, Apr 09, 2026 at 04:00:07PM +0000, Michael Margolin wrote:

> EFA actually has a single counter object type that can count all events
> as you suggest here, but I chose to define a single container for
> success and error completion counts in core for three main reasons:
> 
> 1. Consistency with userspace - we usually have a 1:1 mapping between
>    rdma-core and kernel objects.

Well here we would have two kernel objects right?

> 2. Although the UE spec does not define HW interfaces, it does couple
>    success and error counting.

It's just counting, it seem slike the api is you get a counter and
when certain events happen it counts. You get to pick what incrs that
counter.

> 3. A single object for success and error completions gives more freedom
>    to device implementations. For instance, it allows optimizing device
>    HW resources by implementing the error counter in a less performant
>    way.

This can be done anyhow by choosing fast/slow counters based on the
requested bits to count. If userspace requests an error only counter
it can be routed properly.

Jason