From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC7F3AC00 for ; Wed, 15 Apr 2026 01:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776215147; cv=none; b=rmh8BxPDKVHXVIkQVm2EKlciZCYBn/bJGCKlO+/efFgH+zcMdzBiyWVzB5SsUairzfRunzUf4p23efCI2+7a76abZTUQvvgfuaiOLRimYucdQ4PLRF4QPQj8N2F65VFQPIoKdbR6Djn5n/pSPk1cxSN8W+C014YRThczvkJBrPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776215147; c=relaxed/simple; bh=BsG8+Oe8+psG7NYsx/xpVbw90E9zPpAcmX+DyQIcITc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S1s+1alO0Y2hHUuEhp0rIJ1YnF+00ikNxTHDB+Y6/VdwwdIG+2qyS/L8pe6dBTLrJCJqlC/MtYY6pbwwdFBM9UU3aL+41qt1WTFA59A/o26cpaPw8gqJpcOcYdgOZ5X9X9wLY7v0udOXs3twwJtDDKDsa19ispR7cp9Qy6Xpw+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qZC7qgFa; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qZC7qgFa" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43d734223e4so1955326f8f.0 for ; Tue, 14 Apr 2026 18:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776215144; x=1776819944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5mXBTzw12R6m0VO5N9uDeP+i5xgELPTWIByaKlPH1K8=; b=qZC7qgFarOjcTAFpbvH/Zj90QhM+qoElccJjeE5ruMiNK65MrhRvtQgU+wb6lq4AmM MjarFZhv4t/4ta1yQvRYbzWS6bFPt4rKxurtHdeuLRJ1fxZ3FR+wWiRm0syDofDO6wCO 5VsRlQqtuMKym2uowokiIsAQOVq1ePCoAyLoZ5oq2ySXZitQqNR1ILzOHopzF+5DIWC4 1Tj9h2BVrUTTrJNVRe8EooVG3Ee9vTfa/XrsUSHKdnxeVx/tq51hKYcTP5oc7/UTWcAk P7QgU8aBAGZAcEQChDBoGoNq8ZY20MoodtrYJtcIUq5h10SJbUgOrNwBWcpSqKtXo+G2 tOeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776215144; x=1776819944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5mXBTzw12R6m0VO5N9uDeP+i5xgELPTWIByaKlPH1K8=; b=sPHcKQ+ZXA/gpYk5NkAvSPkfehSazPTmeuZ6dgifAn7vc3JELYsJ3r+tce7f+UM5Br bahThkSxt856dF+ANtHp7rm5cbFokhObL8jWZ5vx4V5rSoTe/Ws5mTd8Qh5iQUCIKrMV F7Oll28O4pJcGGmUEltrOyIqo0ZSmBUf33UloEhI7LO1eLcftY27wtQyzDL9K7SOL0QN SGyOmDfz63wOO3KKTlpbWJc8c1VR4WnbrFLga0gzx2BUBrqD47BtJ5wsBnK960aWd0k/ jp+Uaetvd3wQAtENm+vYPBlpBEOQE410AYLGpenlQmvffYc4nDhpwqfZuBA8qMunDPRz j1vQ== X-Forwarded-Encrypted: i=1; AFNElJ9+63bYsUS/P1hvg/oiovqBa1TAxbVCFjq9g8WgHYvXg7c71X6YX6f9L0xyyOfhbiKBAQPhaftslefd@vger.kernel.org X-Gm-Message-State: AOJu0YxsXCFRv/lu9yfSbFpje0f5ZrTuKOyI4NcDDlSAxTZW3Jab2S7e aPAhSeMx9kF73Lb39080fzRIXZAHh8vGlx6+oP6Zpime3XtMLqeYppFv X-Gm-Gg: AeBDiev9hnWiZHuc7S1vCzLTltMoKQVofO61qve1qg996/bhuhPRDCWbS7WwqH8hsYR MHED9BoHgmyQRi9leXW2nDdcLg3suAestn/pfacp7EdbUfDEWL7SaAR1MjSd4qYTm1omVBVswGI Z8lzse6gGpVCeRCzc8lUO7z14ePtYILoWSje6xVUZkDutaGHO80T7Aw+vp8TknfGC/hywASOIcT 7LPoks06F7pBG7aoqx1zCKhyhRJrQRRAJQpGAC1PZDbxW9rwvhZLuVU+pGZjnUNdpq8dkNTnqbX tsV1DQSZ9n5Oyr6jnjYDixcdie51iKvimHGqrlFrIR6TAKXwnByxtjdBQjtCnAxdnyd7bPEUW1G bUgVdsrL8Y+Bxb2SCZXg+j6GtGueppSct+nB5k6MZbmML7oNjlvX0rBoEXf9qSJ/TlEgJS3dHyr n/JrtQ/i7LY38VU4S19Bl3qFWeMDUmnIjxLzgfjoF31Mb1UgiEhOVIb9modxZ8DUEAOr/0SidPk rjTR/W24Kvh6D0k79SjTmf1l0JdmWRsMREbs1+ACQ== X-Received: by 2002:a05:6000:42ca:b0:43d:7086:b03 with SMTP id ffacd0b85a97d-43d70860b78mr11045470f8f.1.1776215144142; Tue, 14 Apr 2026 18:05:44 -0700 (PDT) Received: from SD.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3d5c8fsm489879f8f.19.2026.04.14.18.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 18:05:42 -0700 (PDT) From: Prathamesh Deshpande To: Leon Romanovsky Cc: Carolina Jubran , Saeed Mahameed , Richard Cochran , Tariq Toukan , Mark Bloch , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] net/mlx5: Fix OOB access and stack information leak in PTP event handling Date: Wed, 15 Apr 2026 02:05:19 +0100 Message-ID: <20260415010535.34855-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260413144610.GJ21470@unreal> References: <20260413144610.GJ21470@unreal> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, Apr 13, 2026 at 05:46:10PM +0300, Leon Romanovsky wrote: > On Sun, Apr 12, 2026 at 01:04:10AM +0100, Prathamesh Deshpande wrote: > > In mlx5_pps_event(), several critical issues were identified: > > > > 1. The 'pin' index from the hardware event was used without bounds > > checking to index 'pin_config' and 'pps_info->start'. Check against > > MAX_PIN_NUM to prevent out-of-bounds access. > > You were told more than once that this is impossible. > > <...> > > > + if (WARN_ON_ONCE(pin >= MAX_PIN_NUM)) > > + return NOTIFY_OK; > > Let's not add useless checks in fast path. Hi Leon, Thanks for the feedback. I've addressed this in v5 by dropping the redundant pin bounds and pin_config checks to keep the fast path clean, focusing strictly on the stack leak and NULL clock guard fixes. Thanks, Prathamesh