From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Margolin <mrgolin@amazon.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, sleybo@amazon.com,
matua@amazon.com, gal.pressman@linux.dev
Subject: Re: [PATCH for-next] RDMA/core: Fix user CQ creation for drivers without create_cq
Date: Fri, 17 Apr 2026 12:20:30 -0300 [thread overview]
Message-ID: <20260417152030.GG761338@nvidia.com> (raw)
In-Reply-To: <20260416201408.13980-1-mrgolin@amazon.com>
On Thu, Apr 16, 2026 at 08:14:08PM +0000, Michael Margolin wrote:
> CQ creation is failing for drivers that only implement create_user_cq
> (e.g. EFA), when buffer isn't provided by userspace. This because of a
> leftover check that requires create_cq existence in such case.
>
> Remove the create_cq existence check from the no-buffer path. The
> buffer is optional and drivers that handle their own memory should work
> through create_user_cq regardless.
>
> Fixes: 584ec74748e6 ("RDMA/core: Prepare create CQ path for API unification")
> Signed-off-by: Michael Margolin <mrgolin@amazon.com>
> ---
> drivers/infiniband/core/uverbs_std_types_cq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied thanks!
Jason
prev parent reply other threads:[~2026-04-17 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 20:14 [PATCH for-next] RDMA/core: Fix user CQ creation for drivers without create_cq Michael Margolin
2026-04-17 15:20 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417152030.GG761338@nvidia.com \
--to=jgg@nvidia.com \
--cc=gal.pressman@linux.dev \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox