From: Leon Romanovsky <leon@kernel.org>
To: Yonatan Nachum <ynachum@amazon.com>
Cc: jgg@nvidia.com, linux-rdma@vger.kernel.org, mrgolin@amazon.com,
sleybo@amazon.com, matua@amazon.com, gal.pressman@linux.dev,
Firas Jahjah <firasj@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Add checksum support for admin responses
Date: Thu, 23 Apr 2026 15:06:21 +0300 [thread overview]
Message-ID: <20260423120621.GC172828@unreal> (raw)
In-Reply-To: <20260420065528.GA29767@dev-dsk-ynachum-1b-aa121316.eu-west-1.amazon.com>
On Mon, Apr 20, 2026 at 06:55:28AM +0000, Yonatan Nachum wrote:
> On Thu, Apr 09, 2026 at 07:49:05AM +0000, Yonatan Nachum wrote:
> > EFA devices added support for CRC16 checksum on admin responses and to
> > expose it to the driver the API version increased to 0.2. Add a check
> > for support on device init and if supported validate the checksum on
> > each admin response the driver receives. If the checksum validation
> > failed, drop the CQE.
> >
> > Add the CRC16 module to Kconfig to have the in-tree dependency.
> >
> > Reviewed-by: Firas Jahjah <firasj@amazon.com>
> > Reviewed-by: Michael Margolin <mrgolin@amazon.com>
> > Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
> > ---
> > drivers/infiniband/hw/efa/Kconfig | 3 +-
> > .../infiniband/hw/efa/efa_admin_cmds_defs.h | 3 --
> > drivers/infiniband/hw/efa/efa_admin_defs.h | 15 +++---
> > drivers/infiniband/hw/efa/efa_com.c | 50 ++++++++++++++++---
> > drivers/infiniband/hw/efa/efa_com.h | 4 +-
> > 5 files changed, 55 insertions(+), 20 deletions(-)
<...>
> >
>
> Kind reminder.
There is nothing to revisit. We are in the merge window, and we do not
accept new features during this period.
Thanks
>
> Thanks
>
prev parent reply other threads:[~2026-04-23 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 7:49 [PATCH for-next] RDMA/efa: Add checksum support for admin responses Yonatan Nachum
2026-04-13 8:35 ` Leon Romanovsky
2026-04-13 9:21 ` Yonatan Nachum
2026-04-13 19:08 ` Leon Romanovsky
2026-04-20 6:55 ` Yonatan Nachum
2026-04-23 12:06 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423120621.GC172828@unreal \
--to=leon@kernel.org \
--cc=firasj@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox