Re: [PATCH rdma-next v2 01/15] RDMA/core: Introduce generic buffer descriptor infrastructure for umem

Jiri Pirko
2026-04-22T10:32:32Z

Tue, Apr 21, 2026 at 02:52:12PM +0200, jgg@ziepe.ca wrote:
>On Thu, Apr 16, 2026 at 12:10:00PM +0000, Michael Margolin wrote:
>> > >> >> @@ -64,6 +64,7 @@ enum {
>> > >> >> UVERBS_ATTR_UHW_IN = UVERBS_ID_DRIVER_NS,
>> > >> >> UVERBS_ATTR_UHW_OUT,
>> > >> >> UVERBS_ID_DRIVER_NS_WITH_UHW,
>> > >> >> + UVERBS_ATTR_BUFFERS,
>>
>> I don't think you can add anything here as it overlaps with driver
>> specific attributes. I suggest defining per command attr id and passing
>> it by caller into ib_umem_list_create.
>
>Right, the expectation would be to have a ATTRS_QP_BUFFERS

Okay. I was under impression I can add a generic attr, I was wrong :/