From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C802A3EF65F for ; Thu, 7 May 2026 12:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158373; cv=none; b=fFj92BWHMUIrU2LdZ0pBzRd05M4nB0XOXI+zi55BUCeyFQiX66AsxxqW+O1HXYTU1Kpk2tcSvFExFDsNoV50GSycAGSZ3eJzA+r/xF3scNx1nq01HLhperH94nMrS1AeBEQB7UsgJL2VvVilNBtCowkhI+tkkdLKTZwo4Bw9rYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778158373; c=relaxed/simple; bh=fWL6+pKQKA74Q72Y0nYPRU+1xmwT9h+zfGf8qrATHAQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AlnjZXmai48AGTDZXXfHe6vAQiTSzls661B2k6HhEn+/vONmVY7OHC9sXvTB+gBi2e+kw5/6uumnmsTRPm/Wn0Z+zBFBD3tJtf7iXlv5AeK8EfFy4jl81NHRFLP5RJVuR0eafz1b/8Fupe6Mi5hSnLOTOe0W46VgKJ0h+jO2dMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b=fmu5Ufea; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b="fmu5Ufea" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-452169ae568so634947f8f.3 for ; Thu, 07 May 2026 05:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1778158370; x=1778763170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZxlttQfz5I4C/XGu5hCBn3Tt89cCs8qCdh8b2GwcCR4=; b=fmu5UfeazPWg4V39DwNgqBbS5tQQgCRTFTiTOMivtR2iaUeTdLDgmZVO+j+dQm0eoT doTejk5QBDfWqHWuPdFENnrYDwplDW9wT4uuVevY0k5+Dkm+IUYYrECEPhiqHVgkqq6d x8SXpOcuo1mVoU5Zx4HI0b8E+V0WyZtUO7z7vdkDhFaO33sr4mk01YsFlAzy4lxkQmdC kZqj029vVJ42LntqkKsWe1wufTeiROyLfOINXS4/tm3YzGq7sLF6RYKmcFr1oOO7+0Lc YYmMjZO1UmncDU3P7NiaRR+htqIbhmKaw0ZRmtO9arUkfXBLyFu5Ddan6SOg4RuCgsnY kYrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778158370; x=1778763170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZxlttQfz5I4C/XGu5hCBn3Tt89cCs8qCdh8b2GwcCR4=; b=rv+ePTCzTwkmnDO990iCj5IS7IbLQ3YGYzTQLXI/8/oG4Qa9im0UuE2CvOkriXJ8PA 8rwNYh9sCxl/YkL8LzItSXZuxNxDYtaF0sWOs+4qVV8WpBIIqQIN5Ad9PmVX9ZnlIzIp /RUPsFFi55iPqv+zRA265ajdIYaF171eNYqQQDcdIAGA/dc+42Mp8cQ0csMJzjURAeK0 6e1ow5cOmZyd/srZqGviTo02rfHhsV9yBwXy1fE2o4kJl96KpJOKc5UAtBWSSryeNeLU 41dqwS/WY16VD4Uls4O1WR6Rr5k3WdGqupJzrKffVwvxmcQpoHRIaj0VPHseOc5IJonq Javw== X-Gm-Message-State: AOJu0YwFzKi2YiYw5ANmBa/lce+1GUp0xXa5K0fx8s0R9IIk2bY4+Rvr Dp+EsNNvFkynyupkcF0WOUxyFfmr8px0oDX4DXxC9jEqbGT6J9VCb+M6XsfIYUIWhtgNnUg1JhP uu9Ww X-Gm-Gg: AeBDies8eQj2iQfUPz0UNYDtxr2NkDvfhGC98QhnRF46H5U6DnFfjLF1O+R82j82Lav ujoh2d4K/QD9lsXWUDjGK8I4s4u3+yW05W23IxHJ7rTh/C5J4XkzClIjjoKEgIKQC2cneIR+dzd h51JZAtHU0PUl/+Jw74kpXKdMlhebJN2j0vfHqfS9Reis+QP98gtIMjlEPblRUNZtqahwgLKj5i 4vq5NdcNtjFu0bXJdv/gA2ZDA6M0+P4s10T54jS/k7fpzRCvp8AFV61Wwl1Nhz3oeHZZB++8RxU 747qLR7zHZci7jTY/vgfxXguQfCOWXhUTnDWGqmKOixtDRWord45IAnY3zc/AdMrKMyxdUAN5Jn 7bYbN9iIsD5N19TAETZCeKIypD0N+i+V4fsa393fbVBGVkQRPtwjLamHVPdkZEfqPF2DOLszKBf JF5eKRoL3bNCYx71llH0d16691Ojng9hV1zWgSZLJNNV055ciYTchJ X-Received: by 2002:a05:6000:26c2:b0:439:b8b2:fad0 with SMTP id ffacd0b85a97d-4515b056c1dmr12905106f8f.5.1778158370020; Thu, 07 May 2026 05:52:50 -0700 (PDT) Received: from localhost (46-13-72-179.customers.tmcz.cz. [46.13.72.179]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45055960811sm21124673f8f.27.2026.05.07.05.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 05:52:49 -0700 (PDT) From: Jiri Pirko To: linux-rdma@vger.kernel.org Cc: jgg@ziepe.ca, leon@kernel.org, mrgolin@amazon.com, gal.pressman@linux.dev, sleybo@amazon.com, parav@nvidia.com, mbloch@nvidia.com, yanjun.zhu@linux.dev, marco.crivellari@suse.com, roman.gushchin@linux.dev, phaddad@nvidia.com, lirongqing@baidu.com, ynachum@amazon.com, huangjunxian6@hisilicon.com, kalesh-anakkur.purayil@broadcom.com, ohartoov@nvidia.com, michaelgur@nvidia.com, shayd@nvidia.com, edwards@nvidia.com, sriharsha.basavapatna@broadcom.com, andrew.gospodarek@broadcom.com, selvin.xavier@broadcom.com Subject: [PATCH rdma-next v4 16/16] RDMA/mlx5: Use UMEM attribute for QP doorbell record Date: Thu, 7 May 2026 14:52:31 +0200 Message-ID: <20260507125231.2950751-17-jiri@resnulli.us> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260507125231.2950751-1-jiri@resnulli.us> References: <20260507125231.2950751-1-jiri@resnulli.us> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jiri Pirko Add an optional mlx5 driver-namespace UMEM attribute on QP create so userspace can supply the doorbell record umem explicitly, symmetric to the CQ side. Resolve it inside mlx5_ib_db_map_user() and use it as a private DBR page when present; otherwise take the existing UHW share-or-pin path that preserves per-page DBR sharing across CQ/QP/SRQ in the same process. Add mlx5's first UVERBS_OBJECT_QP UAPI definition chain to attach the new attr. Signed-off-by: Jiri Pirko --- v2->v3: - moved QP DBR attr to mlx5 driver namespace - added new mlx5_ib_create_qp_defs[] UAPI chain (mlx5 had only a CQ one) - changed to use ib_umem_get_attr() to get umem inside mlx5_ib_db_map_user() --- drivers/infiniband/hw/mlx5/main.c | 1 + drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 + drivers/infiniband/hw/mlx5/qp.c | 19 ++++++++++++++++++- include/uapi/rdma/mlx5_user_ioctl_cmds.h | 4 ++++ 4 files changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 109661c2ac12..a94cf6dd4992 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -4449,6 +4449,7 @@ static const struct uapi_definition mlx5_ib_defs[] = { UAPI_DEF_CHAIN(mlx5_ib_std_types_defs), UAPI_DEF_CHAIN(mlx5_ib_dm_defs), UAPI_DEF_CHAIN(mlx5_ib_create_cq_defs), + UAPI_DEF_CHAIN(mlx5_ib_create_qp_defs), UAPI_DEF_CHAIN_OBJ_TREE(UVERBS_OBJECT_DEVICE, &mlx5_ib_query_context), UAPI_DEF_CHAIN_OBJ_TREE(UVERBS_OBJECT_MR, &mlx5_ib_reg_dmabuf_mr), diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h index 45bc8928523a..5ea0b755a000 100644 --- a/drivers/infiniband/hw/mlx5/mlx5_ib.h +++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h @@ -1511,6 +1511,7 @@ extern const struct uapi_definition mlx5_ib_flow_defs[]; extern const struct uapi_definition mlx5_ib_qos_defs[]; extern const struct uapi_definition mlx5_ib_std_types_defs[]; extern const struct uapi_definition mlx5_ib_create_cq_defs[]; +extern const struct uapi_definition mlx5_ib_create_qp_defs[]; static inline int is_qp1(enum ib_qp_type qp_type) { diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 997ea9bcfc55..d384dd17b19c 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -44,6 +44,9 @@ #include "qp.h" #include "wr.h" +#define UVERBS_MODULE_NAME mlx5_ib +#include + enum { MLX5_IB_ACK_REQ_FREQ = 8, }; @@ -1056,7 +1059,9 @@ static int _create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd, resp->bfreg_index = MLX5_IB_INVALID_BFREG; qp->bfregn = bfregn; - err = mlx5_ib_db_map_user(context, NULL, 0, ucmd->db_addr, &qp->db); + err = mlx5_ib_db_map_user(context, udata, + MLX5_IB_ATTR_CREATE_QP_DBR_BUF_UMEM, + ucmd->db_addr, &qp->db); if (err) { mlx5_ib_dbg(dev, "map failed\n"); goto err_free; @@ -5871,3 +5876,15 @@ void mlx5_ib_qp_event_cleanup(void) { destroy_workqueue(mlx5_ib_qp_event_wq); } + +ADD_UVERBS_ATTRIBUTES_SIMPLE( + mlx5_ib_qp_create, + UVERBS_OBJECT_QP, + UVERBS_METHOD_QP_CREATE, + UVERBS_ATTR_UMEM(MLX5_IB_ATTR_CREATE_QP_DBR_BUF_UMEM, + UA_OPTIONAL)); + +const struct uapi_definition mlx5_ib_create_qp_defs[] = { + UAPI_DEF_CHAIN_OBJ_TREE(UVERBS_OBJECT_QP, &mlx5_ib_qp_create), + {}, +}; diff --git a/include/uapi/rdma/mlx5_user_ioctl_cmds.h b/include/uapi/rdma/mlx5_user_ioctl_cmds.h index b63e75034cda..ddb898afd813 100644 --- a/include/uapi/rdma/mlx5_user_ioctl_cmds.h +++ b/include/uapi/rdma/mlx5_user_ioctl_cmds.h @@ -277,6 +277,10 @@ enum mlx5_ib_create_cq_attrs { MLX5_IB_ATTR_CREATE_CQ_DBR_BUF_UMEM, }; +enum mlx5_ib_create_qp_attrs { + MLX5_IB_ATTR_CREATE_QP_DBR_BUF_UMEM = UVERBS_ID_DRIVER_NS_WITH_UHW, +}; + enum mlx5_ib_reg_dmabuf_mr_attrs { MLX5_IB_ATTR_REG_DMABUF_MR_ACCESS_FLAGS = (1U << UVERBS_ID_NS_SHIFT), }; -- 2.53.0