From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9D2236AB61; Mon, 11 May 2026 12:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778503835; cv=none; b=l5wj9aK0T55iBjWgvx7JbWBFoyv8iQPehkmIfiyMggEB99rF3fWbXiWUWPSHlnaW0/0U/BVFeckV5uzKGEcH4eXuM2v0at3WBMYvBWuSxvhZEiyVDia+FCu5iWI2KhWZrpExMuVpH/xiSp8d0XxlNgzok8QXgTgd/ug7q3+HrRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778503835; c=relaxed/simple; bh=1Twa6uesN0szXFlZCM6LGRSYEhaOeIwnikAIuueSnxo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bU4zReSuW4nC74NjT1fupMSQQF//wzLRVhLYe5g3gjJj9UjUhk5sozv3xwQlV0YdHLEbDPrbRdjQ1nrNi8v89R8D3GJS9SO/EoQfDdYb3wsxTeLZVnjBXGI3M1nj/LRn0mUqwgIHDPQlZpu7uliBGfkQhD0ucC8kld5nLfYHRLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OPKTQvDP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OPKTQvDP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F817C2BCF7; Mon, 11 May 2026 12:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778503835; bh=1Twa6uesN0szXFlZCM6LGRSYEhaOeIwnikAIuueSnxo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OPKTQvDPQ06IKRcxLVqHptCyh4gYE3VvZTq/AEd6CLK+37fVUzKExgAotrOPsvtXe duQ5TYAERrWKHjQOxa/IQbLrzezsZyKS47I3pIo9QsyKxtPVMGtSITAX3IUEuaJEzu r0VCeMYetQdy7i1HrkWIsvzH4+W8M3YG3T29t/I5XSVFqmz5xYMEjukAJJQfOSBLs2 ELHTPWSZWQsoQMzOx6ucrsKXbWLiXfF5rPCCQa+M4rio1EOoPefCD+r3wejRejAA9q 3AB9HzYBkBUCRDLdvI779OawzgorYhqDy28xQtgQPyAqP5NRboSZjjxOu0In1THcEC LHa1gEIZoL1Ag== Date: Mon, 11 May 2026 15:50:28 +0300 From: Leon Romanovsky To: Abhijit Gangurde Cc: jgg@ziepe.ca, brett.creeley@amd.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, allen.hubbe@amd.com, nikhil.agarwal@amd.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] RDMA/ionic: Support QP transport mode selection in create and modify Message-ID: <20260511125028.GJ15586@unreal> References: <20260430123931.3256130-1-abhijit.gangurde@amd.com> <20260430123931.3256130-4-abhijit.gangurde@amd.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430123931.3256130-4-abhijit.gangurde@amd.com> On Thu, Apr 30, 2026 at 06:09:31PM +0530, Abhijit Gangurde wrote: > Allow userspace to specify the QP transport mode and number of > reorder completion queue paths during QP creation and modification. > > Extend ionic_qp_req with transport_mode, num_rcq_paths, and > ionic_flags fields. The transport mode selects the firmware QP type, > ionic_flags are forwarded in the upper bits of priv_flags during > QP creation, and num_rcq_paths is passed to firmware during QP > modify. > > Co-developed-by: Allen Hubbe > Signed-off-by: Allen Hubbe > Signed-off-by: Abhijit Gangurde > --- > .../infiniband/hw/ionic/ionic_controlpath.c | 16 +++++++++++----- > drivers/infiniband/hw/ionic/ionic_fw.h | 18 +++++++++++++++--- > drivers/infiniband/hw/ionic/ionic_ibdev.h | 1 + > include/uapi/rdma/ionic-abi.h | 5 ++++- > 4 files changed, 31 insertions(+), 9 deletions(-) <...> > +enum ionic_qp_transport_mode { > + IONIC_QPT_TRANSPORT_ROCE_V2 = BIT(0), > + IONIC_QPT_TRANSPORT_MRC = BIT(1), > +}; > + > /* admin queue qp type */ > enum ionic_qp_type { > IONIC_QPT_RC, > @@ -228,16 +235,21 @@ enum ionic_qp_type { > IONIC_QPT_XRC_INI, > IONIC_QPT_XRC_TGT, > IONIC_QPT_XRC_SRQ, > + IONIC_QPT_MRC, > }; > > -static inline int to_ionic_qp_type(enum ib_qp_type type) > +static inline int to_ionic_qp_type(enum ib_qp_type type, > + enum ionic_qp_transport_mode tm) > { > switch (type) { > case IB_QPT_GSI: > case IB_QPT_UD: > return IONIC_QPT_UD; > case IB_QPT_RC: > - return IONIC_QPT_RC; > + if (tm == IONIC_QPT_TRANSPORT_MRC) > + return IONIC_QPT_MRC; > + else > + return IONIC_QPT_RC; We have historically treated vendor-specific QP types as special cases and routed them through IB_QPT_DRIVER. IB_QPT_RC represents a standard RC QP and is expected to follow the specification. Thanks